Refactor IDebuggable StepInto/Over/Out methods into void Step(StepType type);

This commit is contained in:
adelikat 2014-12-15 22:19:10 +00:00
parent 00cd8573da
commit d08fb39cb8
20 changed files with 27 additions and 130 deletions

View File

@ -22,8 +22,12 @@ namespace BizHawk.Emulation.Common
IMemoryCallbackSystem MemoryCallbacks { get; } IMemoryCallbackSystem MemoryCallbacks { get; }
// Advanced Navigation // Advanced Navigation
void StepInto(); //void StepInto();
void StepOut(); //void StepOut();
void StepOver(); //void StepOver();
void Step(StepType type);
} }
public enum StepType { Into, Out, Over }
} }

View File

@ -129,12 +129,6 @@ namespace BizHawk.Emulation.Cores.Calculators
public IMemoryCallbackSystem MemoryCallbacks { get; private set; } public IMemoryCallbackSystem MemoryCallbacks { get; private set; }
[FeatureNotImplemented] [FeatureNotImplemented]
public void StepInto() { throw new NotImplementedException(); } public void Step(StepType type) { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOut() { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOver() { throw new NotImplementedException(); }
} }
} }

View File

@ -128,13 +128,7 @@ namespace BizHawk.Emulation.Cores.Computers.Commodore64
} }
[FeatureNotImplemented] [FeatureNotImplemented]
public void StepInto() { throw new NotImplementedException(); } public void Step(StepType type) { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOut() { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOver() { throw new NotImplementedException(); }
public ITracer Tracer public ITracer Tracer
{ {

View File

@ -61,12 +61,6 @@ namespace BizHawk.Emulation.Cores.Atari.Atari2600
public IMemoryCallbackSystem MemoryCallbacks { get; private set; } public IMemoryCallbackSystem MemoryCallbacks { get; private set; }
[FeatureNotImplemented] [FeatureNotImplemented]
public void StepInto() { throw new NotImplementedException(); } public void Step(StepType type) { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOut() { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOver() { throw new NotImplementedException(); }
} }
} }

View File

@ -67,12 +67,6 @@ namespace BizHawk.Emulation.Cores.Atari.Atari7800
} }
[FeatureNotImplemented] [FeatureNotImplemented]
public void StepInto() { throw new NotImplementedException(); } public void Step(StepType type) { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOut() { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOver() { throw new NotImplementedException(); }
} }
} }

View File

@ -134,12 +134,6 @@ namespace BizHawk.Emulation.Cores.ColecoVision
} }
[FeatureNotImplemented] [FeatureNotImplemented]
public void StepInto() { throw new NotImplementedException(); } public void Step(StepType type) { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOut() { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOver() { throw new NotImplementedException(); }
} }
} }

View File

@ -28,13 +28,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.GBA
} }
[FeatureNotImplemented] [FeatureNotImplemented]
public void StepInto() { throw new NotImplementedException(); } public void Step(StepType type) { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOut() { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOver() { throw new NotImplementedException(); }
[FeatureNotImplemented] [FeatureNotImplemented]
public void SetCpuRegister(string register, int value) public void SetCpuRegister(string register, int value)

View File

@ -422,13 +422,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.GBA
} }
[FeatureNotImplemented] [FeatureNotImplemented]
public void StepInto() { throw new NotImplementedException(); } public void Step(StepType type) { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOut() { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOver() { throw new NotImplementedException(); }
#endregion #endregion

View File

@ -290,13 +290,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.Gameboy
} }
[FeatureNotImplemented] [FeatureNotImplemented]
public void StepInto() { throw new NotImplementedException(); } public void Step(StepType type) { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOut() { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOver() { throw new NotImplementedException(); }
#endregion #endregion

View File

@ -448,9 +448,8 @@ namespace BizHawk.Emulation.Cores.Nintendo.Gameboy
MemoryDomains = new MemoryDomainList(mm); MemoryDomains = new MemoryDomainList(mm);
} }
public void StepInto() { throw new NotImplementedException(); } [FeatureNotImplemented]
public void StepOut() { throw new NotImplementedException(); } public void Step(StepType type) { throw new NotImplementedException(); }
public void StepOver() { throw new NotImplementedException(); }
#endregion #endregion

View File

@ -72,13 +72,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.N64
public IMemoryCallbackSystem MemoryCallbacks { get; private set; } public IMemoryCallbackSystem MemoryCallbacks { get; private set; }
[FeatureNotImplemented] [FeatureNotImplemented]
public void StepInto() { throw new NotImplementedException(); } public void Step(StepType type) { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOut() { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOver() { throw new NotImplementedException(); }
private mupen64plusApi.MemoryCallback _readcb; private mupen64plusApi.MemoryCallback _readcb;
private mupen64plusApi.MemoryCallback _writecb; private mupen64plusApi.MemoryCallback _writecb;

View File

@ -943,13 +943,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.NES
} }
[FeatureNotImplemented] [FeatureNotImplemented]
public void StepInto() { throw new NotImplementedException(); } public void Step(StepType type) { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOut() { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOver() { throw new NotImplementedException(); }
public ITracer Tracer { get; private set; } public ITracer Tracer { get; private set; }
public IMemoryCallbackSystem MemoryCallbacks { get; private set; } public IMemoryCallbackSystem MemoryCallbacks { get; private set; }

View File

@ -395,13 +395,7 @@ namespace BizHawk.Emulation.Cores.Consoles.Nintendo.QuickNES
} }
[FeatureNotImplemented] [FeatureNotImplemented]
public void StepInto() { throw new NotImplementedException(); } public void Step(StepType type) { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOut() { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOver() { throw new NotImplementedException(); }
public ITracer Tracer public ITracer Tracer
{ {

View File

@ -255,13 +255,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.SNES
public IMemoryCallbackSystem MemoryCallbacks { get; private set; } public IMemoryCallbackSystem MemoryCallbacks { get; private set; }
[FeatureNotImplemented] [FeatureNotImplemented]
public void StepInto() { throw new NotImplementedException(); } public void Step(StepType type) { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOut() { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOver() { throw new NotImplementedException(); }
[FeatureNotImplemented] [FeatureNotImplemented]
public void SetCpuRegister(string register, int value) public void SetCpuRegister(string register, int value)

View File

@ -566,13 +566,7 @@ namespace BizHawk.Emulation.Cores.PCEngine
} }
[FeatureNotImplemented] [FeatureNotImplemented]
public void StepInto() { throw new NotImplementedException(); } public void Step(StepType type) { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOut() { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOver() { throw new NotImplementedException(); }
[FeatureNotImplemented] [FeatureNotImplemented]
public void SetCpuRegister(string register, int value) public void SetCpuRegister(string register, int value)

View File

@ -293,13 +293,7 @@ namespace BizHawk.Emulation.Cores.Sega.Genesis
} }
[FeatureNotImplemented] [FeatureNotImplemented]
public void StepInto() { throw new NotImplementedException(); } public void Step(StepType type) { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOut() { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOver() { throw new NotImplementedException(); }
[FeatureNotImplemented] [FeatureNotImplemented]
public void SetCpuRegister(string register, int value) public void SetCpuRegister(string register, int value)

View File

@ -601,13 +601,7 @@ namespace BizHawk.Emulation.Cores.Sega.MasterSystem
} }
[FeatureNotImplemented] [FeatureNotImplemented]
public void StepInto() { throw new NotImplementedException(); } public void Step(StepType type) { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOut() { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOver() { throw new NotImplementedException(); }
public void Dispose() { } public void Dispose() { }

View File

@ -644,13 +644,7 @@ namespace BizHawk.Emulation.Cores.Consoles.Sega.gpgx
} }
[FeatureNotImplemented] [FeatureNotImplemented]
public void StepInto() { throw new NotImplementedException(); } public void Step(StepType type) { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOut() { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOver() { throw new NotImplementedException(); }
[FeatureNotImplemented] [FeatureNotImplemented]
public void SetCpuRegister(string register, int value) public void SetCpuRegister(string register, int value)

View File

@ -765,11 +765,7 @@ namespace BizHawk.Emulation.Cores.Sony.PSX
public IMemoryCallbackSystem MemoryCallbacks { get { throw new NotImplementedException(); } } public IMemoryCallbackSystem MemoryCallbacks { get { throw new NotImplementedException(); } }
[FeatureNotImplemented] [FeatureNotImplemented]
public void StepInto() { throw new NotImplementedException(); } public void Step(StepType type) { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOut() { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOver() { throw new NotImplementedException(); }
#endregion //IDebuggable #endregion //IDebuggable
} }

View File

@ -349,13 +349,7 @@ namespace BizHawk.Emulation.Cores.WonderSwan
} }
[FeatureNotImplemented] [FeatureNotImplemented]
public void StepInto() { throw new NotImplementedException(); } public void Step(StepType type) { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOut() { throw new NotImplementedException(); }
[FeatureNotImplemented]
public void StepOver() { throw new NotImplementedException(); }
BizSwan.MemoryCallback ReadCallbackD; BizSwan.MemoryCallback ReadCallbackD;
BizSwan.MemoryCallback WriteCallbackD; BizSwan.MemoryCallback WriteCallbackD;