ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIXME comments for Ares64

This commit is contained in:
CasualPokePlayer 2022-05-26 23:24:58 -07:00
parent 009bff30d7
commit d01728227b
3 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/BizHawk.Emulation.Cores/Consoles/Nintendo/Ares64/Ares64.IDebuggable.cs
View File

@ -21,6 +21,8 @@ namespace BizHawk.Emulation.Cores.Consoles.Nintendo.Ares64
ret.Add("LO", data[32]); ret.Add("LO", data[32]);
ret.Add("HI", data[33]); ret.Add("HI", data[33]);
ret.Add("PC", (uint)data[34]); ret.Add("PC", (uint)data[34]);
// FIXME: the PC register is actually 64-bits (although in practice it will only ever be 32-bits)
// Debugger UI doesn't like it as 64 bits, hence the uint cast
return ret; return ret;
} }

1
src/BizHawk.Emulation.Cores/Consoles/Nintendo/Ares64/Ares64.IDisassemblable.cs
View File

@ -22,6 +22,7 @@ namespace BizHawk.Emulation.Cores.Consoles.Nintendo.Ares64
public override string Disassemble(MemoryDomain m, uint addr, out int length) public override string Disassemble(MemoryDomain m, uint addr, out int length)
{ {
// FIXME: the PC register is actually 64-bits (although in practice it will only ever be 32-bits)
_core.GetDisassembly(addr, m.PeekUint(addr, true), _disasmbuf); _core.GetDisassembly(addr, m.PeekUint(addr, true), _disasmbuf);
length = 4; length = 4;
var ret = Encoding.UTF8.GetString(_disasmbuf); var ret = Encoding.UTF8.GetString(_disasmbuf);

2
src/BizHawk.Emulation.Cores/Consoles/Nintendo/Ares64/Ares64.ITraceable.cs
View File

@ -13,6 +13,8 @@ namespace BizHawk.Emulation.Cores.Consoles.Nintendo.Ares64
private void MakeTrace(IntPtr disasm) private void MakeTrace(IntPtr disasm)
{ {
// FIXME: Something is wrong here, this is called back once and never called back again
// worked fine before v128 merge, probably some upstream regression?
var disasmStr = Mershul.PtrToStringUtf8(disasm); var disasmStr = Mershul.PtrToStringUtf8(disasm);
if (!disasmStr.StartsWith("CPU")) // garbage, ignore if (!disasmStr.StartsWith("CPU")) // garbage, ignore
{ {