From ccc11be8964b9cfc77416dc76fd883e79d1fddec Mon Sep 17 00:00:00 2001 From: YoshiRulz Date: Thu, 28 Jul 2022 05:51:38 +1000 Subject: [PATCH] Explicitly discard required-but-unused `IStatable` service prop --- src/BizHawk.Client.EmuHawk/tools/BasicBot/BasicBot.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/BizHawk.Client.EmuHawk/tools/BasicBot/BasicBot.cs b/src/BizHawk.Client.EmuHawk/tools/BasicBot/BasicBot.cs index 9a73c859a2..88f9f5d68d 100644 --- a/src/BizHawk.Client.EmuHawk/tools/BasicBot/BasicBot.cs +++ b/src/BizHawk.Client.EmuHawk/tools/BasicBot/BasicBot.cs @@ -62,7 +62,6 @@ namespace BizHawk.Client.EmuHawk [RequiredService] private IEmulator Emulator { get; set; } - // Unused, due to the use of MainForm to loadstate, but this needs to be kept here in order to establish an IStatable dependency [RequiredService] private IStatable StatableCore { get; set; } @@ -273,6 +272,8 @@ namespace BizHawk.Client.EmuHawk public override void Restart() { + _ = StatableCore!; // otherwise unused due to loadstating via MainForm; however this service is very much required so the property needs to be present + if (_currentDomain == null || MemoryDomains.Contains(_currentDomain)) {