From cbf1bc6abf56584c144dbbd5fbfe1d8b89779242 Mon Sep 17 00:00:00 2001 From: YoshiRulz Date: Wed, 12 Jun 2024 06:43:05 +1000 Subject: [PATCH] Simplify parsing of `--dump-frames` flag --- src/BizHawk.Client.Common/ArgParser.cs | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/BizHawk.Client.Common/ArgParser.cs b/src/BizHawk.Client.Common/ArgParser.cs index 93320cbbda..1b1b8f5be9 100644 --- a/src/BizHawk.Client.Common/ArgParser.cs +++ b/src/BizHawk.Client.Common/ArgParser.cs @@ -84,15 +84,10 @@ namespace BizHawk.Client.Common else if (argDowncased.StartsWithOrdinal("--dump-frames=")) { string list = argDowncased.Substring(argDowncased.IndexOf('=') + 1); - string[] items = list.Split(','); - currAviWriterFrameList = new HashSet(); - foreach (string item in items) - { - currAviWriterFrameList.Add(int.Parse(item)); - } - + currAviWriterFrameList = new(); + currAviWriterFrameList.AddRange(list.Split(',').Select(int.Parse)); // automatically set dump length to maximum frame - autoDumpLength = currAviWriterFrameList.Order().Last(); + autoDumpLength = currAviWriterFrameList.Max(); } else if (argDowncased.StartsWithOrdinal("--version")) {