ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Optimize operations with selected items

This commit is contained in:
Morilli 2024-03-14 08:48:11 +01:00 committed by James Groom
parent 2a67cf93ec
commit ca0fb69570
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/BizHawk.Client.EmuHawk/CustomControls/InputRoll/InputRoll.cs
View File

@ -10,6 +10,7 @@ using BizHawk.Client.Common;
using BizHawk.Client.EmuHawk.CustomControls;
using BizHawk.Common;
using BizHawk.Common.CollectionExtensions;
using CollectionExtensions = BizHawk.Common.CollectionExtensions.CollectionExtensions;
// TODO: There are some bad interactions between ScrollToIndex and MakeIndexVisible that are preventing things from working as intended.
// But, the current behaviour is ok for now for what it is used for.
@ -267,7 +268,7 @@ namespace BizHawk.Client.EmuHawk
_rowCount = value;
//TODO replace this with a binary search + truncate
if (_selectedItems.Max(s => s.RowIndex) >= _rowCount)
if (_selectedItems.LastOrDefault()?.RowIndex >= _rowCount)
{
_selectedItems.RemoveAll(i => i.RowIndex >= _rowCount);
}
@ -623,13 +624,13 @@ namespace BizHawk.Client.EmuHawk
[Browsable(false)]
[DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
public int? SelectionStartIndex
=> AnyRowsSelected ? SelectedRowsWithDuplicates.Min() : null;
=> AnyRowsSelected ? SelectedRowsWithDuplicates.First() : null;
/// <returns>the <see cref="Cell.RowIndex"/> of the selected row with the latest index, or <see langword="null"/> if no rows are selected</returns>
[Browsable(false)]
[DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
public int? SelectionEndIndex
=> AnyRowsSelected ? SelectedRowsWithDuplicates.Max() : null;
=> AnyRowsSelected ? SelectedRowsWithDuplicates.Last() : null;
/// <summary>
/// Gets or sets the current Cell that the mouse was in.

1
src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.MenuItems.cs
View File

@ -619,6 +619,7 @@ namespace BizHawk.Client.EmuHawk
}
CurrentTasMovie.RemoveFrames(TasView.SelectedRows.ToArray());
SetTasViewRowCount();
SetSplicer();
if (needsToRollback)