From c9c1aa91adac1fdbf335cb81965e50021d0df394 Mon Sep 17 00:00:00 2001 From: zeromus Date: Tue, 9 Jun 2020 23:27:49 -0500 Subject: [PATCH] fix temp directory pathing in path manager which was previously making no attempt to do the right thing (fixes #2118). did I do this right? I don't see what was so hard about it in the first place, but I had left a todo there..... i dunno --- .../config/PathEntryCollectionExtensions.cs | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/BizHawk.Client.Common/config/PathEntryCollectionExtensions.cs b/src/BizHawk.Client.Common/config/PathEntryCollectionExtensions.cs index 17138b9a67..9cd371fa63 100644 --- a/src/BizHawk.Client.Common/config/PathEntryCollectionExtensions.cs +++ b/src/BizHawk.Client.Common/config/PathEntryCollectionExtensions.cs @@ -320,12 +320,10 @@ namespace BizHawk.Client.Common /// public static void RefreshTempPath(this PathEntryCollection collection) { - if (!string.IsNullOrWhiteSpace(collection.TempFilesFragment)) - { - // TODO - BUG - needs to route through PathManager.MakeAbsolutePath or something similar, but how? - string target = collection.TempFilesFragment; - TempFileManager.HelperSetTempPath(target); - } + if (string.IsNullOrWhiteSpace(collection.TempFilesFragment)) + return; + var path = collection.AbsolutePathFor(collection.TempFilesFragment, null); + TempFileManager.HelperSetTempPath(path); } private static string ResolveToolsPath(this PathEntryCollection collection, string subPath)