From c994e7bc84263194b5438340f1a4dd83ea968bc6 Mon Sep 17 00:00:00 2001 From: Asnivor Date: Thu, 5 Sep 2024 14:16:08 +0100 Subject: [PATCH] [ChannelFHawk] Fix the chess (Schach) computer 'thinking' activity LED (the original cart had an LED built into it - we are using the DriveActivity indicator in Bizhawk for this purpose) --- .../Consoles/Fairchild/ChannelF/Cart/VesCartBase.cs | 1 + .../Consoles/Fairchild/ChannelF/Cart/mapper_SCHACH.cs | 7 +++---- .../Consoles/Fairchild/ChannelF/ChannelF.cs | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/BizHawk.Emulation.Cores/Consoles/Fairchild/ChannelF/Cart/VesCartBase.cs b/src/BizHawk.Emulation.Cores/Consoles/Fairchild/ChannelF/Cart/VesCartBase.cs index 4037ef7ca3..a8586264d6 100644 --- a/src/BizHawk.Emulation.Cores/Consoles/Fairchild/ChannelF/Cart/VesCartBase.cs +++ b/src/BizHawk.Emulation.Cores/Consoles/Fairchild/ChannelF/Cart/VesCartBase.cs @@ -171,6 +171,7 @@ namespace BizHawk.Emulation.Cores.Consoles.ChannelF m_addr_latch = 0; m_read_write = 0; m_data0 = 0; + ActivityLED = false; } public virtual void SyncState(Serializer ser) diff --git a/src/BizHawk.Emulation.Cores/Consoles/Fairchild/ChannelF/Cart/mapper_SCHACH.cs b/src/BizHawk.Emulation.Cores/Consoles/Fairchild/ChannelF/Cart/mapper_SCHACH.cs index 128828758f..178cf4be9b 100644 --- a/src/BizHawk.Emulation.Cores/Consoles/Fairchild/ChannelF/Cart/mapper_SCHACH.cs +++ b/src/BizHawk.Emulation.Cores/Consoles/Fairchild/ChannelF/Cart/mapper_SCHACH.cs @@ -48,12 +48,11 @@ } else if (addr == 0x3800) { - // activity LED - ActivityLED = !ActivityLED; + ActivityLED = false; } - else + else if (addr == 0x8000) { - + ActivityLED = true; } } diff --git a/src/BizHawk.Emulation.Cores/Consoles/Fairchild/ChannelF/ChannelF.cs b/src/BizHawk.Emulation.Cores/Consoles/Fairchild/ChannelF/ChannelF.cs index ae2a7e995b..e9d68cbee4 100644 --- a/src/BizHawk.Emulation.Cores/Consoles/Fairchild/ChannelF/ChannelF.cs +++ b/src/BizHawk.Emulation.Cores/Consoles/Fairchild/ChannelF/ChannelF.cs @@ -74,6 +74,6 @@ namespace BizHawk.Emulation.Cores.Consoles.ChannelF public bool DriveLightEnabled => true; - public bool DriveLightOn => !Cartridge.ActivityLED; + public bool DriveLightOn => Cartridge.ActivityLED; } }