From c934e6b5d1faa294beddcbabd37ab44a0fba28e1 Mon Sep 17 00:00:00 2001
From: YoshiRulz <OSSYoshiRulz+git@gmail.com>
Date: Wed, 29 Jan 2025 23:08:53 +1000
Subject: [PATCH] Memoise reflection in `HeaderKeys.Contains`

only used for `.bkm` anyway
---
 src/BizHawk.Client.Common/movie/HeaderKeys.cs | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/src/BizHawk.Client.Common/movie/HeaderKeys.cs b/src/BizHawk.Client.Common/movie/HeaderKeys.cs
index 2ec87ba6cb..169446ca3f 100644
--- a/src/BizHawk.Client.Common/movie/HeaderKeys.cs
+++ b/src/BizHawk.Client.Common/movie/HeaderKeys.cs
@@ -1,4 +1,6 @@
-using System.Linq;
+using System.Collections.Frozen;
+using System.Collections.Generic;
+using System.Linq;
 
 namespace BizHawk.Client.Common
 {
@@ -27,10 +29,14 @@ namespace BizHawk.Client.Common
 		public const string VsyncAttoseconds = "VsyncAttoseconds"; // used for Arcade due to it representing thousands of different systems with different vsync rates
 		public const string Core = "Core";
 
-		public static bool Contains(string val) =>
-			typeof(HeaderKeys)
-				.GetFields()
-				.Select(field => field.GetValue(null).ToString())
-				.Contains(val);
+		private static FrozenSet<string> _allValues;
+
+		private static ISet<string> AllValues
+			=> _allValues ??= typeof(HeaderKeys).GetFields()
+				.Select(static field => field.GetValue(null).ToString())
+				.ToFrozenSet();
+
+		public static bool Contains(string val)
+			=> AllValues.Contains(val);
 	}
 }