From c891cc2cb5eb16968506a5ef8531595f204437d9 Mon Sep 17 00:00:00 2001
From: YoshiRulz <OSSYoshiRulz@gmail.com>
Date: Thu, 3 Nov 2022 11:58:19 +1000
Subject: [PATCH] Don't ignore mGBA skip BIOS setting when recording (resolves
 #2465)

also disable skip BIOS with TAS profile and enable with Casual profile
also removed `DeterministicEmulation ||= !SkipBios`, does it matter?
---
 src/BizHawk.Client.EmuHawk/config/ProfileConfig.cs   | 12 +++++++++++-
 .../Consoles/Nintendo/GBA/MGBAHawk.cs                |  4 ++--
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/src/BizHawk.Client.EmuHawk/config/ProfileConfig.cs b/src/BizHawk.Client.EmuHawk/config/ProfileConfig.cs
index f674d37ada..41af2c6044 100644
--- a/src/BizHawk.Client.EmuHawk/config/ProfileConfig.cs
+++ b/src/BizHawk.Client.EmuHawk/config/ProfileConfig.cs
@@ -10,6 +10,7 @@ using BizHawk.Emulation.Cores.Sega.MasterSystem;
 using BizHawk.Emulation.Cores.ColecoVision;
 using BizHawk.Emulation.Cores.Atari.Atari2600;
 using BizHawk.Emulation.Cores.Nintendo.Gameboy;
+using BizHawk.Emulation.Cores.Nintendo.GBA;
 
 namespace BizHawk.Client.EmuHawk
 {
@@ -142,6 +143,11 @@ namespace BizHawk.Client.EmuHawk
 			var s = GetSyncSettings<Gameboy, Gameboy.GambatteSyncSettings>();
 			s.EnableBIOS = false;
 			PutSyncSettings<Gameboy>(s);
+
+			// GBA
+			var mGBASettings = GetSyncSettings<MGBAHawk, MGBAHawk.SyncSettings>();
+			mGBASettings.SkipBios = true;
+			PutSyncSettings<MGBAHawk>(mGBASettings);
 		}
 
 		private void SetLongPlay()
@@ -221,7 +227,11 @@ namespace BizHawk.Client.EmuHawk
 			var s = GetSyncSettings<Gameboy, Gameboy.GambatteSyncSettings>();
 			s.EnableBIOS = true;
 			PutSyncSettings<Gameboy>(s);
-			
+
+			// GBA
+			var mGBASettings = GetSyncSettings<MGBAHawk, MGBAHawk.SyncSettings>();
+			mGBASettings.SkipBios = false;
+			PutSyncSettings<MGBAHawk>(mGBASettings);
 		}
 
 		private void SetN64Tas()
diff --git a/src/BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/MGBAHawk.cs b/src/BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/MGBAHawk.cs
index 2cf68f0321..007064baf3 100644
--- a/src/BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/MGBAHawk.cs
+++ b/src/BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/MGBAHawk.cs
@@ -32,14 +32,14 @@ namespace BizHawk.Emulation.Cores.Nintendo.GBA
 			if (bios is { Length: not 0x4000 }) throw new InvalidOperationException("BIOS must be exactly 16384 bytes!");
 			if (deterministic && bios is null) throw new MissingFirmwareException("A BIOS is required for deterministic recordings!");
 			DeterministicEmulation = deterministic
-				|| (bios is not null && !_syncSettings.RTCUseRealTime && !_syncSettings.SkipBios); // in this case, the core is deterministic even though it wasn't asked to be
+				|| (bios is not null && !_syncSettings.RTCUseRealTime); // in this case, the core is deterministic even though it wasn't asked to be
 
 			Core = LibmGBA.BizCreate(
 				bios,
 				file,
 				file.Length,
 				GetOverrideInfo(_syncSettings),
-				skipBios: _syncSettings.SkipBios && !DeterministicEmulation);
+				skipBios: _syncSettings.SkipBios);
 			if (Core == IntPtr.Zero)
 			{
 				throw new InvalidOperationException($"{nameof(LibmGBA.BizCreate)}() returned NULL!  Bad BIOS? and/or ROM?");