ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

implement dirty checking for N64 settings

This commit is contained in:
Morilli 2024-10-18 13:28:25 +02:00
parent 13584ceb62
commit c68dd703dc
2 changed files with 4 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/BizHawk.Emulation.Cores/Consoles/Nintendo/N64/N64.ISettable.cs
View File

@ -8,7 +8,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.N64
{ {
public N64Settings GetSettings() public N64Settings GetSettings()
{ {
return _settings.Clone(); return _settings with { };
} }
public N64SyncSettings GetSyncSettings() public N64SyncSettings GetSyncSettings()
@ -18,8 +18,9 @@ namespace BizHawk.Emulation.Cores.Nintendo.N64
public PutSettingsDirtyBits PutSettings(N64Settings o) public PutSettingsDirtyBits PutSettings(N64Settings o)
{ {
bool changed = o != _settings;
_settings = o; _settings = o;
return PutSettingsDirtyBits.RebootCore; return changed ? PutSettingsDirtyBits.RebootCore : PutSettingsDirtyBits.None;
} }
public PutSettingsDirtyBits PutSyncSettings(N64SyncSettings o) public PutSettingsDirtyBits PutSyncSettings(N64SyncSettings o)

13
src/BizHawk.Emulation.Cores/Consoles/Nintendo/N64/N64Settings.cs
View File

@ -1,21 +1,10 @@
namespace BizHawk.Emulation.Cores.Nintendo.N64 namespace BizHawk.Emulation.Cores.Nintendo.N64
{ {
public class N64Settings public record N64Settings
{ {
public int VideoSizeX = 320; public int VideoSizeX = 320;
public int VideoSizeY = 240; public int VideoSizeY = 240;
public bool UseMupenStyleLag { get; set; } public bool UseMupenStyleLag { get; set; }
public N64Settings Clone()
{
return new N64Settings
{
VideoSizeX = VideoSizeX,
VideoSizeY = VideoSizeY,
UseMupenStyleLag = UseMupenStyleLag
};
}
} }
} }