ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

EmuVersion needs updating on saving, not loading; I made the wrong call of where to put this originally, but the interaction with PlayMovie slipped my mind. (#2202)

This commit is contained in:
RetroEdit 2020-07-05 21:29:06 +00:00 committed by GitHub
parent 72993a3bd0
commit c12d2fa570
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/BizHawk.Client.Common/movie/bk2/Bk2Movie.IO.cs
View File

@ -53,6 +53,12 @@ namespace BizHawk.Client.Common
protected virtual void Write(string fn, bool isBackup = false)
{
SetCycleValues(); // We are pretending these only need to be set on save
// EmulatorVersion used to store the unchanging original emulator version.
if (!Header.ContainsKey(HeaderKeys.OriginalEmulatorVersion))
{
Header[HeaderKeys.OriginalEmulatorVersion] = Header[HeaderKeys.EmulatorVersion];
}
Header[HeaderKeys.EmulatorVersion] = VersionInfo.GetEmuVersion();
CreateDirectoryIfNotExists(fn);
using var bs = new ZipStateSaver(fn, Session.Settings.MovieCompressionLevel);
@ -166,12 +172,6 @@ namespace BizHawk.Client.Common
}
}
});
// EmulatorVersion used to store the unchanging original emulator version.
if (!Header.ContainsKey(HeaderKeys.OriginalEmulatorVersion))
{
Header[HeaderKeys.OriginalEmulatorVersion] = Header[HeaderKeys.EmulatorVersion];
}
Header[HeaderKeys.EmulatorVersion] = VersionInfo.GetEmuVersion();
bl.GetLump(BinaryStateLump.Comments, false, delegate(TextReader tr)
{