ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Enable SA1212 and fix non-compliance 

"Property accessors should follow order" (setter should not come before getter)
This commit is contained in:
YoshiRulz 2020-09-08 22:23:10 +10:00
parent 0dd89de0d8
commit bf3f037bd7
No known key found for this signature in database
GPG Key ID: C4DE31C245353FB7
4 changed files with 34 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Common.ruleset
View File

@ -401,9 +401,6 @@
<!-- Using alias directives should be ordered alphabetically by alias name -->
<Rule Id="SA1211" Action="Hidden" />
<!-- Property accessors should follow order -->
<Rule Id="SA1212" Action="Hidden" />
<!-- Readonly fields should appear before non-readonly fields -->
<Rule Id="SA1214" Action="Hidden" />
</Rules>

2
src/BizHawk.Emulation.Cores/Consoles/Nintendo/NES/PPU.cs
View File

@ -17,8 +17,8 @@ namespace BizHawk.Emulation.Cores.Nintendo.NES
Region _region;
public Region region
{
set { _region = value; SyncRegion(); }
get => _region;
set { _region = value; SyncRegion(); }
}
void SyncRegion()
{

64
src/BizHawk.Emulation.Cores/Consoles/Nintendo/SNES/SNESGraphicsDecoder.cs
View File

@ -271,44 +271,44 @@ namespace BizHawk.Emulation.Cores.Nintendo.SNES
public ModeInfo Mode = new ModeInfo();
public bool Mode1_BG3_Priority { private set; get; }
public bool Mode1_BG3_Priority { get; private set; }
public bool SETINI_Mode7ExtBG { private set; get; }
public bool SETINI_HiRes { private set; get; }
public bool SETINI_Overscan { private set; get; }
public bool SETINI_ObjInterlace { private set; get; }
public bool SETINI_ScreenInterlace { private set; get; }
public bool SETINI_Mode7ExtBG { get; private set; }
public bool SETINI_HiRes { get; private set; }
public bool SETINI_Overscan { get; private set; }
public bool SETINI_ObjInterlace { get; private set; }
public bool SETINI_ScreenInterlace { get; private set; }
public int CGWSEL_ColorMask { private set; get; }
public int CGWSEL_ColorSubMask { private set; get; }
public int CGWSEL_AddSubMode { private set; get; }
public bool CGWSEL_DirectColor { private set; get; }
public int CGADSUB_AddSub { private set; get; }
public bool CGADSUB_Half { private set; get; }
public int CGWSEL_ColorMask { get; private set; }
public int CGWSEL_ColorSubMask { get; private set; }
public int CGWSEL_AddSubMode { get; private set; }
public bool CGWSEL_DirectColor { get; private set; }
public int CGADSUB_AddSub { get; private set; }
public bool CGADSUB_Half { get; private set; }
public int OBSEL_Size { private set; get; }
public int OBSEL_NameSel { private set; get; }
public int OBSEL_NameBase { private set; get; }
public int OBSEL_Size { get; private set; }
public int OBSEL_NameSel { get; private set; }
public int OBSEL_NameBase { get; private set; }
public int OBJTable0Addr { private set; get; }
public int OBJTable1Addr { private set; get; }
public int OBJTable0Addr { get; private set; }
public int OBJTable1Addr { get; private set; }
public bool OBJ_MainEnabled { private set; get; }
public bool OBJ_SubEnabled { private set; get; }
public bool OBJ_MathEnabled { private set; get; }
public bool BK_MathEnabled { private set; get; }
public bool OBJ_MainEnabled { get; private set; }
public bool OBJ_SubEnabled { get; private set; }
public bool OBJ_MathEnabled { get; private set; }
public bool BK_MathEnabled { get; private set; }
public int M7HOFS { private set; get; }
public int M7VOFS { private set; get; }
public int M7A { private set; get; }
public int M7B { private set; get; }
public int M7C { private set; get; }
public int M7D { private set; get; }
public int M7X { private set; get; }
public int M7Y { private set; get; }
public int M7SEL_REPEAT { private set; get; }
public bool M7SEL_HFLIP { private set; get; }
public bool M7SEL_VFLIP { private set; get; }
public int M7HOFS { get; private set; }
public int M7VOFS { get; private set; }
public int M7A { get; private set; }
public int M7B { get; private set; }
public int M7C { get; private set; }
public int M7D { get; private set; }
public int M7X { get; private set; }
public int M7Y { get; private set; }
public int M7SEL_REPEAT { get; private set; }
public bool M7SEL_HFLIP { get; private set; }
public bool M7SEL_VFLIP { get; private set; }
public static ScreenInfo GetScreenInfo(LibsnesApi api)
{

2
src/BizHawk.Emulation.Cores/Consoles/PC Engine/ADPCM.cs
View File

@ -38,8 +38,8 @@ namespace BizHawk.Emulation.Cores.PCEngine
public byte Port180A
{
set { WritePending = true; WriteTimer = 24; WriteBuffer = value; }
get { ReadPending = true; ReadTimer = 24; return ReadBuffer; }
set { WritePending = true; WriteTimer = 24; WriteBuffer = value; }
}
public byte Port180B;