Enable SA1208 and fix noncompliance (except in Cores)

"System using directives should be placed before other using directives"
This commit is contained in:
YoshiRulz 2020-11-30 21:26:36 +10:00
parent 1a020ba0f5
commit be36c60e9e
No known key found for this signature in database
GPG Key ID: C4DE31C245353FB7
13 changed files with 24 additions and 20 deletions

View File

@ -393,7 +393,7 @@
<Rule Id="SA1204" Action="Hidden" /> <Rule Id="SA1204" Action="Hidden" />
<!-- System using directives should be placed before other using directives --> <!-- System using directives should be placed before other using directives -->
<Rule Id="SA1208" Action="Hidden" /> <Rule Id="SA1208" Action="Error" />
<!-- Using directives should be ordered alphabetically by namespace --> <!-- Using directives should be ordered alphabetically by namespace -->
<Rule Id="SA1210" Action="Hidden" /> <Rule Id="SA1210" Action="Hidden" />

View File

@ -1,9 +1,10 @@
using BizHawk.Emulation.Common; using System;
using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.IO; using System.IO;
using System.Linq; using System.Linq;
using BizHawk.Emulation.Common;
namespace BizHawk.Client.Common namespace BizHawk.Client.Common
{ {
public interface IMovieImport public interface IMovieImport

View File

@ -1,8 +1,9 @@
using BizHawk.Emulation.Common; using System;
using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.IO; using System.IO;
using BizHawk.Emulation.Common;
namespace BizHawk.Client.Common namespace BizHawk.Client.Common
{ {
internal class BkmMovie internal class BkmMovie

View File

@ -1,8 +1,9 @@
using BizHawk.Client.Common; using System;
using System;
using System.Drawing; using System.Drawing;
using System.Windows.Forms; using System.Windows.Forms;
using BizHawk.Client.Common;
namespace BizHawk.Client.EmuHawk namespace BizHawk.Client.EmuHawk
{ {
public partial class MessageEdit : UserControl public partial class MessageEdit : UserControl

View File

@ -1,7 +1,8 @@
using BizHawk.Client.Common; using System;
using System;
using System.Windows.Forms; using System.Windows.Forms;
using BizHawk.Client.Common;
namespace BizHawk.Client.EmuHawk namespace BizHawk.Client.EmuHawk
{ {
public partial class MessageRow : UserControl public partial class MessageRow : UserControl

View File

@ -2,12 +2,12 @@
using System.Collections.Generic; using System.Collections.Generic;
using System.ComponentModel; using System.ComponentModel;
using System.Drawing; using System.Drawing;
using System.IO;
using System.Linq; using System.Linq;
using System.Windows.Forms; using System.Windows.Forms;
using BizHawk.Client.Common; using BizHawk.Client.Common;
using NLua; using NLua;
using System.IO;
namespace BizHawk.Client.EmuHawk namespace BizHawk.Client.EmuHawk
{ {

View File

@ -1,9 +1,9 @@
using System; using System;
using System.Collections.Generic;
using System.Drawing; using System.Drawing;
using System.Windows.Forms; using System.Windows.Forms;
using NLua; using NLua;
using System.Collections.Generic;
namespace BizHawk.Client.EmuHawk namespace BizHawk.Client.EmuHawk
{ {

View File

@ -1,9 +1,9 @@
using System; using System;
using System.IO;
using System.Windows.Forms; using System.Windows.Forms;
using BizHawk.Common; using BizHawk.Common;
using BizHawk.Client.Common; using BizHawk.Client.Common;
using System.IO;
namespace BizHawk.Client.EmuHawk namespace BizHawk.Client.EmuHawk
{ {

View File

@ -1,12 +1,11 @@
using System; using System;
using System.Drawing; using System.Drawing;
using System.Windows.Forms;
using BizHawk.Emulation.Cores.PCEngine;
using System.Drawing.Imaging; using System.Drawing.Imaging;
using System.Windows.Forms;
using BizHawk.Client.Common; using BizHawk.Client.Common;
using BizHawk.Emulation.Common; using BizHawk.Emulation.Common;
using BizHawk.Emulation.Cores.PCEngine;
namespace BizHawk.Client.EmuHawk namespace BizHawk.Client.EmuHawk
{ {

View File

@ -1,11 +1,11 @@
using System; using System;
using System.Drawing; using System.Drawing;
using System.Windows.Forms; using System.Windows.Forms;
using BizHawk.Emulation.Cores.Sega.MasterSystem;
using System.Drawing.Imaging; using System.Drawing.Imaging;
using BizHawk.Client.Common; using BizHawk.Client.Common;
using BizHawk.Emulation.Common; using BizHawk.Emulation.Common;
using BizHawk.Emulation.Cores.Sega.MasterSystem;
namespace BizHawk.Client.EmuHawk namespace BizHawk.Client.EmuHawk
{ {

View File

@ -1,10 +1,10 @@
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Drawing;
using System.Linq; using System.Linq;
using System.Windows.Forms; using System.Windows.Forms;
using BizHawk.Emulation.Common; using BizHawk.Emulation.Common;
using System.Drawing;
using BizHawk.Client.Common; using BizHawk.Client.Common;
namespace BizHawk.Client.EmuHawk namespace BizHawk.Client.EmuHawk

View File

@ -1,7 +1,8 @@
using BizHawk.Common; using System;
using System;
using System.Runtime.InteropServices; using System.Runtime.InteropServices;
using BizHawk.Common;
namespace BizHawk.Emulation.Common namespace BizHawk.Emulation.Common
{ {
public class MemoryDomainDelegate : MemoryDomain public class MemoryDomainDelegate : MemoryDomain

View File

@ -5,7 +5,7 @@
<Import Project="../MainSlnCommon.props" /> <Import Project="../MainSlnCommon.props" />
<PropertyGroup> <PropertyGroup>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks> <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<NoWarn>$(NoWarn);SA1205;SA1400</NoWarn> <NoWarn>$(NoWarn);SA1205;SA1208;SA1400</NoWarn>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>
<PackageReference Include="Microsoft.CSharp" Version="4.7.0" /> <PackageReference Include="Microsoft.CSharp" Version="4.7.0" />