From bded999177c181d3f692dfc14a63f478e343b720 Mon Sep 17 00:00:00 2001
From: adelikat <adelikat@tasvideos.org>
Date: Mon, 24 Nov 2014 00:38:29 +0000
Subject: [PATCH] Create a FeatureNotImplemented attribute, the intend of which
 is to apply to any unimplemented method of an ICoreService method/property,
 set some methods in Intellivision to this, and have CoreFeatureAnalysis look
 for the presence of this attribute and report unimplemented
 properties/methods

---
 BizHawk.Client.EmuHawk/CoreFeatureAnalysis.cs | 48 ++++++++++++++++---
 BizHawk.Emulation.Common/Extensions.cs        | 13 +++++
 .../Interfaces/ICoreService.cs                | 13 ++++-
 .../Consoles/Intellivision/Intellivision.cs   |  7 ++-
 4 files changed, 72 insertions(+), 9 deletions(-)

diff --git a/BizHawk.Client.EmuHawk/CoreFeatureAnalysis.cs b/BizHawk.Client.EmuHawk/CoreFeatureAnalysis.cs
index ee162830b3..3ef368f828 100644
--- a/BizHawk.Client.EmuHawk/CoreFeatureAnalysis.cs
+++ b/BizHawk.Client.EmuHawk/CoreFeatureAnalysis.cs
@@ -90,22 +90,54 @@ namespace BizHawk.Client.EmuHawk
 						ForeColor = isImplemented ? Color.Black : Color.Red
 					};
 
+					bool fullyImplementedInterface = isImplemented;
+
 					if (isImplemented)
 					{
-						foreach (var field in service.GetProperties())
+						foreach (var field in service.GetMethods().OrderBy(f => f.Name))
 						{
-							serviceNode.Nodes.Add(new TreeNode
+							try
 							{
-								Text = field.Name
-							});
+								var coreImplementation = core.CoreType.GetMethod(field.Name);
+
+								if (coreImplementation != null)
+								{
+									var i = coreImplementation.IsImplemented();
+									serviceNode.Nodes.Add(new TreeNode
+									{
+										Text = field.Name,
+										ImageKey = i ? "Good" : "Bad",
+										SelectedImageKey = i ? "Good" : "Bad",
+										StateImageKey = i ? "Good" : "Bad"
+									});
+
+									if (!i)
+									{
+										fullyImplementedInterface = false;
+									}
+								}
+							}
+							catch (Exception ex)
+							{
+								// TODO: SavestateBinary() and SaveStateBinary(BinaryWriter bw) cause an exception, need to look at signature too
+							}
 						}
 
-						foreach (var field in service.GetMethods())
+						foreach (var field in service.GetProperties().OrderBy(f => f.Name))
 						{
+							var i = field.IsImplemented();
 							serviceNode.Nodes.Add(new TreeNode
 							{
-								Text = field.Name
+								Text = field.Name,
+								ImageKey = i ? "Good" : "Bad",
+								SelectedImageKey = i ? "Good" : "Bad",
+								StateImageKey = i ? "Good" : "Bad"
 							});
+
+							if (!i)
+							{
+								fullyImplementedInterface = false;
+							}
 						}
 					}
 					else
@@ -113,10 +145,12 @@ namespace BizHawk.Client.EmuHawk
 						missingImplementation = true;
 					}
 
+					serviceNode.StateImageKey = serviceNode.SelectedImageKey = serviceNode.ImageKey = fullyImplementedInterface ? "Good" : "Bad";
+
 					coreNode.Nodes.Add(serviceNode);
 				}
 
-				coreNode.ImageKey = missingImplementation ? "Bad" : "Good";
+				coreNode.StateImageKey = coreNode.SelectedImageKey = coreNode.ImageKey = missingImplementation ? "Bad" : "Good";
 
 				CoreTree.Nodes.Add(coreNode);
 			}
diff --git a/BizHawk.Emulation.Common/Extensions.cs b/BizHawk.Emulation.Common/Extensions.cs
index acf5257526..b84b23e31f 100644
--- a/BizHawk.Emulation.Common/Extensions.cs
+++ b/BizHawk.Emulation.Common/Extensions.cs
@@ -1,4 +1,6 @@
 using System;
+using System.Linq;
+using System.Reflection;
 
 namespace BizHawk.Emulation.Common.IEmulatorExtensions
 {
@@ -13,5 +15,16 @@ namespace BizHawk.Emulation.Common.IEmulatorExtensions
 		{
 			return core is IMemoryDomains;
 		}
+
+		// TODO: a better place for these
+		public static bool IsImplemented(this MethodInfo info)
+		{
+			return !info.GetCustomAttributes(false).OfType<FeatureNotImplemented>().Any();
+		}
+
+		public static bool IsImplemented(this PropertyInfo info)
+		{
+			return !info.GetCustomAttributes(false).OfType<FeatureNotImplemented>().Any();
+		}
 	}
 }
diff --git a/BizHawk.Emulation.Common/Interfaces/ICoreService.cs b/BizHawk.Emulation.Common/Interfaces/ICoreService.cs
index 720db94a1a..030469f420 100644
--- a/BizHawk.Emulation.Common/Interfaces/ICoreService.cs
+++ b/BizHawk.Emulation.Common/Interfaces/ICoreService.cs
@@ -1,4 +1,6 @@
-namespace BizHawk.Emulation.Common
+using System;
+
+namespace BizHawk.Emulation.Common
 {
 	/// <summary>
 	/// This interface specifies that an interface or implementation is a emulator core service, such as IDebuggable,
@@ -8,4 +10,13 @@
 	public interface ICoreService
 	{
 	}
+
+	/// <summary>
+	/// Should be added to any field of an ICoreService that is not implemented.  By Convention it should also throw a NotImplementedException
+	/// Any feature that does not have this attribute is assumed to be implemented
+	/// </summary>
+	public class FeatureNotImplemented : Attribute
+	{
+		public FeatureNotImplemented() { }
+	}
 }
diff --git a/BizHawk.Emulation.Cores/Consoles/Intellivision/Intellivision.cs b/BizHawk.Emulation.Cores/Consoles/Intellivision/Intellivision.cs
index b70e8e4656..4351fd42df 100644
--- a/BizHawk.Emulation.Cores/Consoles/Intellivision/Intellivision.cs
+++ b/BizHawk.Emulation.Cores/Consoles/Intellivision/Intellivision.cs
@@ -168,29 +168,34 @@ namespace BizHawk.Emulation.Cores.Intellivision
 			//IsLagFrame = false;
 		}
 
+		[FeatureNotImplemented]
 		public void SaveStateText(TextWriter writer)
 		{
 			throw new NotImplementedException();
 		}
 
+		[FeatureNotImplemented]
 		public void LoadStateText(TextReader reader)
 		{
 			throw new NotImplementedException();
 		}
 
+		[FeatureNotImplemented]
 		public void SaveStateBinary(BinaryWriter writer)
 		{
 			throw new NotImplementedException();
 		}
 
+		[FeatureNotImplemented]
 		public void LoadStateBinary(BinaryReader reader)
 		{
 			throw new NotImplementedException();
 		}
 
+		[FeatureNotImplemented]
 		public byte[] SaveStateBinary()
 		{
-			return new byte[0];
+			throw new NotImplementedException();
 		}
 
 		public bool BinarySaveStatesPreferred { get { return false; } }