From bcee6d4d39f07ea9b276ca550929aa7eae3d09ce Mon Sep 17 00:00:00 2001 From: alyosha-tas Date: Sat, 9 Jan 2021 22:20:16 -0500 Subject: [PATCH] Fix syncless recorder --- src/BizHawk.Client.EmuHawk/AVOut/AVSync.cs | 6 ++++++ src/BizHawk.Client.EmuHawk/AVOut/SynclessRecorder.cs | 8 ++++++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/BizHawk.Client.EmuHawk/AVOut/AVSync.cs b/src/BizHawk.Client.EmuHawk/AVOut/AVSync.cs index 4b93be4827..8e1cb12609 100644 --- a/src/BizHawk.Client.EmuHawk/AVOut/AVSync.cs +++ b/src/BizHawk.Client.EmuHawk/AVOut/AVSync.cs @@ -185,6 +185,12 @@ namespace BizHawk.Client.EmuHawk public new virtual void SetFrame(int frame) { // this writer will never support this capability + + // but it needs to for syncless recorder, otherwise it won't work at all + if (W is SynclessRecorder) + { + W.SetFrame(frame); + } } /// always diff --git a/src/BizHawk.Client.EmuHawk/AVOut/SynclessRecorder.cs b/src/BizHawk.Client.EmuHawk/AVOut/SynclessRecorder.cs index 22103f7e29..7731608bf6 100644 --- a/src/BizHawk.Client.EmuHawk/AVOut/SynclessRecorder.cs +++ b/src/BizHawk.Client.EmuHawk/AVOut/SynclessRecorder.cs @@ -54,7 +54,7 @@ namespace BizHawk.Client.EmuHawk public void AddFrame(IVideoProvider source) { - using var bb = new BitmapBuffer(source.BufferWidth, source.BufferHeight, source.GetVideoBuffer()); + using var bb = new BitmapBuffer(source.BufferWidth, source.BufferHeight, source.GetVideoBuffer()); string subPath = GetAndCreatePathForFrameNum(_mCurrFrame); string path = $"{subPath}.png"; bb.ToSysdrawingBitmap().Save(path, ImageFormat.Png); @@ -153,9 +153,13 @@ namespace BizHawk.Client.EmuHawk public static string GetPathFragmentForFrameNum(int index) { - var chunks = StringChunkSplit(index.ToString(), 2); + // not sure of the original purpose here, but the subfolders it makes don't seem to work right, just return frame number for now + /* + var chunks = StringChunkSplit(index.ToString(), 2); string subPath = string.Join("/", chunks); return subPath; + */ + return index.ToString(); } } }