ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix known-failing test case list being unsorted, add warning for that

This commit is contained in:
YoshiRulz 2022-04-30 11:33:18 +10:00
parent 14984aea2d
commit bc922fb6d0
No known key found for this signature in database
GPG Key ID: C4DE31C245353FB7
4 changed files with 42 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/BizHawk.Common/Extensions/CollectionExtensions.cs
View File

@ -168,5 +168,33 @@ namespace BizHawk.Common.CollectionExtensions
}
return c - list.Count;
}
public static bool IsSortedAsc<T>(this IReadOnlyList<T> list)
where T : IComparable<T>
{
for (int i = 0, e = list.Count - 1; i < e; i++) if (list[i + 1].CompareTo(list[i]) < 0) return false;
return true;
}
public static bool IsSortedAsc<T>(this ReadOnlySpan<T> span)
where T : IComparable<T>
{
for (int i = 0, e = span.Length - 1; i < e; i++) if (span[i + 1].CompareTo(span[i]) < 0) return false;
return true;
}
public static bool IsSortedDesc<T>(this IReadOnlyList<T> list)
where T : IComparable<T>
{
for (int i = 0, e = list.Count - 1; i < e; i++) if (list[i + 1].CompareTo(list[i]) > 0) return false;
return true;
}
public static bool IsSortedDesc<T>(this ReadOnlySpan<T> span)
where T : IComparable<T>
{
for (int i = 0, e = span.Length - 1; i < e; i++) if (span[i + 1].CompareTo(span[i]) > 0) return false;
return true;
}
}
}

4
src/BizHawk.Tests.Testroms.GB.GambatteSuite/GambatteSuite.Cases.cs
View File

@ -12,7 +12,7 @@ namespace BizHawk.Tests.Testroms.GB.GambatteSuite
{
public static readonly GambatteHexStrTestCase Dummy = new("missing_files", new(CoreNames.Gambatte, ConsoleVariant.DMG), string.Empty, string.Empty);
public static readonly IReadOnlyCollection<string> KnownFailures = new[]
public static readonly IReadOnlyList<string> KnownFailures = new[]
{
"cgbpal_m3.cgbpal_m3end_1_cgb04c_out7 on CGB_C in GBHawk",
"cgbpal_m3.cgbpal_m3end_3_cgb04c_out0 on CGB_C in GBHawk",
@ -2952,7 +2952,7 @@ namespace BizHawk.Tests.Testroms.GB.GambatteSuite
{
public static readonly GambatteRefImageTestCase Dummy = new("missing_files", new(CoreNames.Gambatte, ConsoleVariant.DMG), string.Empty, string.Empty);
public static readonly IReadOnlyCollection<string> KnownFailures = new[]
public static readonly IReadOnlyList<string> KnownFailures = new[]
{
"bgen.bgoff_bgon_sprite_below_window on CGB_C in SameBoy",
"bgen.bgoff_bgon_sprite_below_window on CGB_C in SameBoy (no BIOS)",

5
src/BizHawk.Tests.Testroms.GB.GambatteSuite/GambatteSuite.cs
View File

@ -81,7 +81,10 @@ namespace BizHawk.Tests.Testroms.GB.GambatteSuite
[ClassInitialize]
public static void BeforeAll(TestContext ctx)
=> TestUtils.PrepareDBAndOutput(SUITE_ID);
{
if (!(GambatteHexStrTestCase.KnownFailures.IsSortedAsc() && GambatteHexStrTestCase.KnownFailures.IsSortedAsc())) throw new Exception(SUITE_ID + " known-failing testcase list must be sorted");
TestUtils.PrepareDBAndOutput(SUITE_ID);
}
private static (IReadOnlyList<GambatteRefImageTestCase> RefImageCases, IReadOnlyList<GambatteHexStrTestCase> HexStrCases) EnumerateAllCases()
{

12
src/BizHawk.Tests.Testroms.GB/GB_GBC/MealybugTearoomTests.cs
View File

@ -3,6 +3,7 @@ using System.Collections.Generic;
using System.Linq;
using System.Reflection;
using BizHawk.Common.CollectionExtensions;
using BizHawk.Common.IOExtensions;
using BizHawk.Common.StringExtensions;
using BizHawk.Emulation.Common;
@ -23,7 +24,7 @@ namespace BizHawk.Tests.Testroms.GB
{
public static readonly MealybugTestCase Dummy = new("missing_files", new(CoreNames.Gambatte, ConsoleVariant.DMG), string.Empty, string.Empty);
public static readonly IReadOnlyCollection<string> KnownFailures = new[]
public static readonly IReadOnlyList<string> KnownFailures = new[]
{
"m2_win_en_toggle on CGB_C in SameBoy (no BIOS)",
"m3_bgp_change on CGB_C in Gambatte", // Gambatte's GBC emulation matches CGB D variant
@ -80,11 +81,11 @@ namespace BizHawk.Tests.Testroms.GB
"m3_lcdc_obj_en_change_variant on DMG in SameBoy", // SameBoy emulates DMG-B, but there's no DMG-B-specific expect image for this test, so it should be the same on all DMG revisions?
"m3_lcdc_obj_en_change_variant on DMG in SameBoy (no BIOS)", // SameBoy emulates DMG-B, but there's no DMG-B-specific expect image for this test, so it should be the same on all DMG revisions?
"m3_lcdc_obj_size_change on CGB_C in GBHawk",
"m3_lcdc_obj_size_change on CGB_C in SameBoy",
"m3_lcdc_obj_size_change on CGB_C in SameBoy (no BIOS)",
"m3_lcdc_obj_size_change on DMG in Gambatte",
"m3_lcdc_obj_size_change on DMG in Gambatte (no BIOS)",
"m3_lcdc_obj_size_change on DMG in GBHawk",
"m3_lcdc_obj_size_change on CGB_C in SameBoy",
"m3_lcdc_obj_size_change on CGB_C in SameBoy (no BIOS)",
"m3_lcdc_obj_size_change on DMG in SameBoy",
"m3_lcdc_obj_size_change on DMG in SameBoy (no BIOS)",
"m3_lcdc_obj_size_change_scx on CGB_C in GBHawk",
@ -260,7 +261,10 @@ namespace BizHawk.Tests.Testroms.GB
[ClassInitialize]
public static void BeforeAll(TestContext ctx)
=> TestUtils.PrepareDBAndOutput(SUITE_ID);
{
if (!MealybugTestCase.KnownFailures.IsSortedAsc()) throw new Exception(SUITE_ID + " known-failing testcase list must be sorted");
TestUtils.PrepareDBAndOutput(SUITE_ID);
}
[DataTestMethod]
[MealybugTestData]