ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update comment on CorePickerUIData 

also restore systemid default core restore logic that exists for some reason
This commit is contained in:
Morilli 2024-07-08 06:26:57 +02:00
parent 45002e6870
commit bbb3b4cd7d
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/BizHawk.Client.Common/config/Config.cs
View File

@ -18,7 +18,7 @@ namespace BizHawk.Client.Common
public static string ControlDefaultPath => Path.Combine(PathUtils.ExeDirectoryPath, "defctrl.json"); public static string ControlDefaultPath => Path.Combine(PathUtils.ExeDirectoryPath, "defctrl.json");
/// <remarks> /// <remarks>
/// <c>AppliesTo[0]</c> is used as the group label, and /// All SystemIDs in <c>AppliesTo</c> are used as group label, and
/// <c>Config.PreferredCores[AppliesTo[0]]</c> (lookup on global <see cref="Config"/> instance) determines which option is shown as checked.<br/> /// <c>Config.PreferredCores[AppliesTo[0]]</c> (lookup on global <see cref="Config"/> instance) determines which option is shown as checked.<br/>
/// The order within submenus and the order of the submenus themselves are determined by the declaration order here. /// The order within submenus and the order of the submenus themselves are determined by the declaration order here.
/// </remarks> /// </remarks>

5
src/BizHawk.Client.EmuHawk/MainForm.cs
View File

@ -107,8 +107,9 @@ namespace BizHawk.Client.EmuHawk
{ {
// invalid --> default (doing this here rather than when reading config file to allow for hacked-in values, though I'm not sure if that could do anything at the moment --yoshi) // invalid --> default (doing this here rather than when reading config file to allow for hacked-in values, though I'm not sure if that could do anything at the moment --yoshi)
var defaultCore = coreNames[0]; var defaultCore = coreNames[0];
Console.WriteLine($"setting preferred core for {appliesTo[0]} etc. to {defaultCore} (was {preferred ?? "null"})"); Console.WriteLine($"setting preferred core for {submenu.Text} to {defaultCore} (was {preferred ?? "null"})");
Config.PreferredCores[appliesTo[0]] = preferred = defaultCore; preferred = defaultCore;
foreach (var sysID in appliesTo) Config.PreferredCores[sysID] = preferred;
} }
foreach (ToolStripMenuItem entry in ((ToolStripMenuItem) openedSender).DropDownItems) entry.Checked = entry.Text == preferred; foreach (ToolStripMenuItem entry in ((ToolStripMenuItem) openedSender).DropDownItems) entry.Checked = entry.Text == preferred;
}; };