ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Lua - refactor console logging to use a string builder to concat messages, reduces the actual call to the console to 1 call, greatly improving performance (less calls to scrolling and other methods that invoke drawing)

This commit is contained in:
adelikat 2020-07-02 12:29:37 -05:00
parent 8e79f0d5e2
commit bb7f933429
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/BizHawk.Client.EmuHawk/tools/Lua/Libraries/ConsoleLuaLibrary.cs
View File

@ -92,34 +92,38 @@ namespace BizHawk.Client.EmuHawk
); );
} }
static void SerializeAndWrite(object output) => GlobalWin.Tools.LuaConsole.WriteToOutputWindow(
output is LuaTable table
? SerializeTable(table)
: output?.ToString() ?? "nil"
);
if (!GlobalWin.Tools.Has<LuaConsole>()) if (!GlobalWin.Tools.Has<LuaConsole>())
{ {
return; return;
} }
var sb = new StringBuilder();
void SerializeAndWrite(object output) => sb.Append(
output is LuaTable table
? SerializeTable(table)
: output?.ToString() ?? "nil"
);
if (outputs == null) if (outputs == null)
{ {
GlobalWin.Tools.LuaConsole.WriteToOutputWindow($"(no return){terminator}"); sb.Append($"(no return){terminator}");
return; return;
} }
SerializeAndWrite(outputs[0]); SerializeAndWrite(outputs[0]);
for (int outIndex = 1, indexAfterLast = outputs.Length; outIndex != indexAfterLast; outIndex++) for (int outIndex = 1, indexAfterLast = outputs.Length; outIndex != indexAfterLast; outIndex++)
{ {
GlobalWin.Tools.LuaConsole.WriteToOutputWindow(separator); sb.Append(separator);
SerializeAndWrite(outputs[outIndex]); SerializeAndWrite(outputs[outIndex]);
} }
if (!string.IsNullOrEmpty(terminator)) if (!string.IsNullOrEmpty(terminator))
{ {
GlobalWin.Tools.LuaConsole.WriteToOutputWindow(terminator); sb.Append(terminator);
} }
GlobalWin.Tools.LuaConsole.WriteToOutputWindow(sb.ToString());
} }
} }
} }