ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

do firmware hash calculation differently without needing a buffer, for users with GBs of roms in their firmware folder

This commit is contained in:
zeromus 2014-11-12 01:27:11 +00:00
parent 92e2b9d610
commit ba0eca8a69
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
BizHawk.Client.Common/FirmwareManager.cs
View File

@ -70,7 +70,6 @@ namespace BizHawk.Client.Common
public class RealFirmwareReader : IDisposable
{
byte[] buffer = new byte[0];
System.Security.Cryptography.SHA1 sha1 = System.Security.Cryptography.SHA1.Create();
public void Dispose()
{
@ -81,20 +80,12 @@ namespace BizHawk.Client.Common
{
var rff = new RealFirmwareFile { FileInfo = fi };
long len = fi.Length;
if (len > buffer.Length)
{
buffer = new byte[len];
}
using (var fs = fi.OpenRead())
{
fs.Read(buffer, 0, (int)len);
sha1.ComputeHash(fs);
}
//without this, the file reading will make bad GC behaviour
GC.Collect();
sha1.ComputeHash(buffer, 0, (int)len);
rff.Hash = sha1.Hash.BytesToHexString();
dict[rff.Hash] = rff;
_files.Add(rff);