ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

EmuHawk: Change deterministic back to how it was before. TRUE if a movie is queued, FALSE if not (and let the cores manage this setting further down the foodchain if they want to). Without this, mGBA skipbios will never work #1432

This commit is contained in:
Asnivor 2019-01-08 11:53:27 +00:00
parent 4a6a6079b0
commit b7f2363584
1 changed files with 6 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
BizHawk.Client.EmuHawk/MainForm.cs
View File

@ -3594,25 +3594,18 @@ namespace BizHawk.Client.EmuHawk
if (args.Deterministic == null) if (args.Deterministic == null)
{ {
// force deterministic in this case // movies should require deterministic emulation in ALL cases
// this is usually null for most cores // if the core is managing its own DE through SyncSettings a 'deterministic' bool can be passed into the core's constructor
// previously this was getting set to false if a movie was not queued for recording - surely that can't be good.. // it is then up to the core itself to override its own local DeterministicEmulation setting
deterministic = true; // if a movie is *not* queued then make this false (this is needed for mGBA logic and is how things were working before I changed them -Asni)
} deterministic = Global.MovieSession.QueuedMovie != null;
}
else else
{ {
// a value was actually supplied somehow - use this // a value was actually supplied somehow - use this
deterministic = args.Deterministic.Value; deterministic = args.Deterministic.Value;
} }
if (Global.MovieSession.QueuedMovie != null)
{
// movies should require deterministic emulation in ALL cases
// if the core is managing its own DE through SyncSettings a 'deterministic' bool should be passed into the core's constructor
// it is then up to the core itself to override its own local DeterministicEmulation setting
deterministic = true;
}
if (!GlobalWin.Tools.AskSave()) if (!GlobalWin.Tools.AskSave())
{ {
return false; return false;