From b62f4bc6a99240fe015311f27faa8a1f4aa18603 Mon Sep 17 00:00:00 2001
From: alyosha-tas <alexei.f.k@gmail.com>
Date: Sun, 6 Jun 2021 10:00:57 -0400
Subject: [PATCH] TAStudio: make operation of 'show player #' buttons more
 intuitive, fixes #2779

---
 .../tools/TAStudio/TAStudio.MenuItems.cs                      | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.MenuItems.cs b/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.MenuItems.cs
index 5850dd31b8..1b03299968 100644
--- a/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.MenuItems.cs
+++ b/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.MenuItems.cs
@@ -1339,10 +1339,12 @@ namespace BizHawk.Client.EmuHawk
 					ToolStripMenuItem dummyObject = playerMenus[i];
 					item.CheckedChanged += (o, ev) =>
 					{
+						// TODO: preserve underlying button checked state and make this a master visibility control
 						foreach (ToolStripMenuItem menuItem in dummyObject.DropDownItems)
 						{
-							menuItem.Checked ^= true;
+							menuItem.Checked = item.Checked;
 						}
+						dummyObject.Visible = item.Checked;
 
 						CurrentTasMovie.FlagChanges();
 						TasView.AllColumns.ColumnsChanged();