From b5893c0a0b860b0d3a16e7d3bca2087a588ec39c Mon Sep 17 00:00:00 2001 From: Morilli <35152647+Morilli@users.noreply.github.com> Date: Wed, 7 May 2025 04:37:06 +0200 Subject: [PATCH] fix tastudio SaveTas implementation somewhat fixes 21fbee01de0847a5ffa840b9a460b33e41418c90 I guess, in particular AskSaveChanges would not save if no file name had been chosen. This doesn't behave correctly when trying to save a backup or bk2 but when no filename has been chosen that makes no sense anyway, so... --- .../tools/TAStudio/TAStudio.MenuItems.cs | 9 +-------- src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.cs | 6 +++++- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.MenuItems.cs b/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.MenuItems.cs index 9a95ba5cad..39a8584ad0 100644 --- a/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.MenuItems.cs +++ b/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.MenuItems.cs @@ -115,14 +115,7 @@ namespace BizHawk.Client.EmuHawk private void SaveTasMenuItem_Click(object sender, EventArgs e) { - if (string.IsNullOrEmpty(CurrentTasMovie.Filename) || CurrentTasMovie.Filename == DefaultTasProjName()) - { - SaveAsTas(); - } - else - { - SaveTas(); - } + SaveTas(); if (Settings.BackupPerFileSave) { SaveTas(saveBackup: true); diff --git a/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.cs b/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.cs index a620db9ad7..b0aed56635 100644 --- a/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.cs +++ b/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.cs @@ -690,7 +690,11 @@ namespace BizHawk.Client.EmuHawk private void SaveTas(bool saveAsBk2 = false, bool saveBackup = false) { - if (string.IsNullOrEmpty(CurrentTasMovie.Filename) || CurrentTasMovie.Filename == DefaultTasProjName()) return; + if (string.IsNullOrEmpty(CurrentTasMovie.Filename) || CurrentTasMovie.Filename == DefaultTasProjName()) + { + SaveAsTas(); + return; + } _autosaveTimer.Stop(); MessageStatusLabel.Text = saveBackup