From b294c69046d412978c94405546231b7aac4799e6 Mon Sep 17 00:00:00 2001 From: goyuken Date: Thu, 13 Feb 2014 18:14:01 +0000 Subject: [PATCH] NES: MMC1 code cleanup, no changes --- .../Consoles/Nintendo/NES/Boards/SxROM.cs | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/BizHawk.Emulation.Cores/Consoles/Nintendo/NES/Boards/SxROM.cs b/BizHawk.Emulation.Cores/Consoles/Nintendo/NES/Boards/SxROM.cs index 5a5bbefa83..d2315e3658 100644 --- a/BizHawk.Emulation.Cores/Consoles/Nintendo/NES/Boards/SxROM.cs +++ b/BizHawk.Emulation.Cores/Consoles/Nintendo/NES/Boards/SxROM.cs @@ -23,14 +23,15 @@ namespace BizHawk.Emulation.Cores.Nintendo.NES //Zelda 2 //Castlevania 2 + // TODO -- different MMC1 revisions handle wram_disable differently; on some it doesn't work at all; on others, + // it works, but with different initial states possible. we only emulate the first case + public sealed class MMC1 { - NES.NESBoardBase board; public MMC1_SerialController scnt = new MMC1_SerialController(); - public MMC1(NES.NESBoardBase board) + public MMC1() { - this.board = board; scnt.WriteRegister = SerialWriteRegister; scnt.Reset = SerialReset; @@ -415,7 +416,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.NES protected void BaseConfigure() { - mmc1 = new MMC1(this); + mmc1 = new MMC1(); prg_mask = (Cart.prg_size / 16) - 1; vram_mask = (Cart.vram_size*1024) - 1; chr_mask = (Cart.chr_size / 8 * 2) - 1;