Remove NES _iskeyboard - This is implemented (although not well tested) already

BizHawk.Emulation.Cores/Consoles/Nintendo/NES/Boards/NROM.cs

@@ -69,7 +69,6 @@ namespace BizHawk.Emulation.Cores.Nintendo.NES
 				case "HVC-FAMILYBASIC":
 					// we don't emulate the controller, so this won't work
 					AssertPrg(32); AssertChr(8); AssertWram(2, 4);
-					NES._iskeyboard = true;
 					break;
 
 				default:

BizHawk.Emulation.Cores/Consoles/Nintendo/NES/NES.Core.cs

@@ -35,8 +35,6 @@ namespace BizHawk.Emulation.Cores.Nintendo.NES
 		//user configuration 
 		int[] palette_compiled = new int[64 * 8];
 
-		//variable to change controller read/write behaviour when keyboard is attached
-		public bool _iskeyboard = false;
 		//variable set when VS system games are running
 		internal bool _isVS = false;
 		//some VS games have a ppu that switches 2000 and 2001, so keep trcak of that
@@ -577,12 +575,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.NES
 					}
 				case 0x4017:
 					{
-						if (_iskeyboard)
-						{
-							// eventually this will be the keyboard function, but for now it is a place holder (no keys pressed)
-							return 0x1E;
-						}
-						else if (_isVS)
+						if (_isVS)
 						{
 							byte ret = 0;
 							// for whatever reason, in VS left and right controller have swapped regs
@@ -674,11 +667,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.NES
 				case 0x4014: Exec_OAMDma(val); break;
 				case 0x4015: apu.WriteReg(addr, val); break;
 				case 0x4016:
-					if (_iskeyboard)
-					{
-						// eventually keyboard emulation will go here
-					}
-					else if (_isVS)
+					if (_isVS)
 					{
 						write_joyport(val);
 						VS_chr_reg = (byte)((val & 0x4)>>2);

BizHawk.Emulation.Cores/Consoles/Nintendo/NES/NES.IStatable.cs

@@ -63,7 +63,6 @@ namespace BizHawk.Emulation.Cores.Nintendo.NES
 			ser.Sync("cpu_step", ref cpu_step);
 			ser.Sync("cpu_stepcounter", ref cpu_stepcounter);
 			ser.Sync("cpu_deadcounter", ref cpu_deadcounter);
-			ser.Sync("keyboard", ref _iskeyboard);
 
 			//oam related
 			ser.Sync("Oam_Dma_Index", ref oam_dma_index);