I've heard bad things about ElementAt()

This commit is contained in:
feos 2018-03-27 19:00:59 +03:00
parent 35c87c5aea
commit ae6ce00d7c
3 changed files with 12 additions and 13 deletions

View File

@ -101,7 +101,7 @@ namespace BizHawk.Client.Common
{
for (int i = firstIndex; i < Markers.Count; i++)
{
TasMovieMarker m = Markers.ElementAt(i);
TasMovieMarker m = Markers[i];
if (m.Frame == frame)
{
Markers.Remove(m);
@ -152,7 +152,7 @@ namespace BizHawk.Client.Common
{
for (int i = firstIndex; i < Markers.Count; i++)
{
TasMovieMarker m = Markers.ElementAt(i);
TasMovieMarker m = Markers[i];
if (m.Frame == frame)
{
Markers.Remove(m);
@ -198,7 +198,7 @@ namespace BizHawk.Client.Common
{
for (int i = firstIndex; i < Markers.Count; i++)
{
TasMovieMarker m = Markers.ElementAt(i);
TasMovieMarker m = Markers[i];
if (m.Frame < removeUpTo)
{
Markers.Remove(m);
@ -241,7 +241,7 @@ namespace BizHawk.Client.Common
{
for (int i = firstIndex; i < Markers.Count; i++)
{
TasMovieMarker m = Markers.ElementAt(i);
TasMovieMarker m = Markers[i];
Markers.Move(m.Frame, m.Frame + 1);
}
}
@ -274,7 +274,7 @@ namespace BizHawk.Client.Common
{
for (int i = firstIndex; i < Markers.Count; i++)
{
TasMovieMarker m = Markers.ElementAt(i);
TasMovieMarker m = Markers[i];
Markers.Move(m.Frame, m.Frame + inputLog.Count());
}
}
@ -363,7 +363,7 @@ namespace BizHawk.Client.Common
{
for (int i = firstIndex; i < Markers.Count; i++)
{
TasMovieMarker m = Markers.ElementAt(i);
TasMovieMarker m = Markers[i];
Markers.Move(m.Frame, m.Frame + count, fromHistory);
}
}

View File

@ -271,7 +271,7 @@ namespace BizHawk.Client.Common
return;
}
StateManagerState state = _states.ElementAt(index).Value;
StateManagerState state = _states.Values[index];
if (state.IsOnDisk)
{
@ -407,11 +407,10 @@ namespace BizHawk.Client.Common
{
continue;
}
KeyValuePair<int, StateManagerState> kvp = _states.ElementAt(i);
bw.Write(kvp.Key);
bw.Write(kvp.Value.Length);
bw.Write(kvp.Value.State);
bw.Write(_states.Keys[i]);
bw.Write(_states.Values[i].Length);
bw.Write(_states.Values[i].State);
}
}

View File

@ -183,7 +183,7 @@ namespace BizHawk.Client.EmuHawk
{
for (var i = _luaForms.Count - 1; i >= 0; i--)
{
_luaForms.ElementAt(i).Close();
_luaForms[i].Close();
}
}