clarification to the saveram flushing system

BizHawk.Client.Common/config/Binding.cs

@@ -129,7 +129,7 @@ namespace BizHawk.Client.Common
 						Bind("General", "Open ROM", "Ctrl+O"),
 						Bind("General", "Close ROM", "Ctrl+W"),
 						Bind("General", "Load Last ROM"),
-						Bind("General", "Flush SRAM", "Ctrl+S"),
+						Bind("General", "Flush SaveRAM", "Ctrl+S"),
 						Bind("General", "Display FPS"),
 						Bind("General", "Frame Counter"),
 						Bind("General", "Lag Counter"),

BizHawk.Client.EmuHawk/MainForm.Designer.cs

@@ -895,7 +895,7 @@
             this.SaveRAMSubMenu.Name = "SaveRAMSubMenu";
             this.SaveRAMSubMenu.Size = new System.Drawing.Size(159, 22);
             this.SaveRAMSubMenu.Text = "Save &RAM";
-            this.SaveRAMSubMenu.DropDownOpened += new System.EventHandler(this.SaveRAMSubMenu_DropDownOpened);
+            this.SaveRAMSubMenu.DropDownOpened += new System.EventHandler(this.FlushSaveRAMSubMenu_DropDownOpened);
             // 
             // FlushSaveRAMMenuItem
             // 

BizHawk.Client.EmuHawk/MainForm.Events.cs

@@ -2181,12 +2181,12 @@ namespace BizHawk.Client.EmuHawk
 
 		private void FlushSaveRAMMenuItem_Click(object sender, EventArgs e)
 		{
-			SaveRam();
+			FlushSaveRAM();
 		}
 
-		private void SaveRAMSubMenu_DropDownOpened(object sender, EventArgs e)
+		private void FlushSaveRAMSubMenu_DropDownOpened(object sender, EventArgs e)
 		{
-			this.FlushSaveRAMMenuItem.ShortcutKeyDisplayString = Global.Config.HotkeyBindings["Save SRAM"].Bindings;
+			this.FlushSaveRAMMenuItem.ShortcutKeyDisplayString = Global.Config.HotkeyBindings["Flush SRAM"].Bindings;
 		}
 
 		#endregion

BizHawk.Client.EmuHawk/MainForm.Hotkey.cs

@@ -63,8 +63,8 @@ namespace BizHawk.Client.EmuHawk
 				case "Load Last ROM":
 					LoadRomFromRecent(Global.Config.RecentRoms.MostRecent);
 					break;
-				case "Flush SRAM":
-					SaveRam();
+				case "Flush SaveRAM":
+					FlushSaveRAM();
 					break;
 				case "Display FPS":
 					ToggleFPS();

BizHawk.Client.EmuHawk/MainForm.cs

@@ -1589,7 +1589,7 @@ namespace BizHawk.Client.EmuHawk
 			}
 		}
 
-		public void SaveRam()
+		public void FlushSaveRAM()
 		{
 			if (Emulator.HasSaveRam())
 			{
@@ -3658,7 +3658,7 @@ namespace BizHawk.Client.EmuHawk
 			}
 			else if (Emulator.HasSaveRam() && Emulator.AsSaveRam().SaveRamModified)
 			{
-				SaveRam();
+				FlushSaveRAM();
 			}
 
 			StopAv();

BizHawk.Client.EmuHawk/tools/Lua/Libraries/EmuLuaLibrary.Client.cs

@@ -540,7 +540,7 @@ namespace BizHawk.Client.EmuHawk
 			)]
 		public void SaveRam()
 		{
-			GlobalWin.MainForm.SaveRam();
+			GlobalWin.MainForm.FlushSaveRAM();
 		}
 	}
 }

BizHawk.Emulation.Common/Interfaces/Services/ISaveRam.cs

@@ -1,7 +1,7 @@
 namespace BizHawk.Emulation.Common
 {
 	/// <summary>
-	/// This service provides the system by which a client can request SRam data to be stored by the client
+	/// This service provides the system by which a client can request SaveRAM data to be stored by the client
 	/// SaveRam encompasses things like battery backed ram, memory cards, and data saved to disk drives
 	/// If available, save files will be automatically loaded when loading a ROM,
 	/// In addition the client will provide features like SRAM-anchored movies, and ways to clear SaveRam
@@ -10,6 +10,7 @@
 	{
 		/// <summary>
 		/// Returns a copy of the SaveRAM. Editing it won't do you any good unless you later call StoreSaveRam()
+		/// TODO: Prescribe whether this is allowed to return null in case there is no SaveRAM
 		/// </summary>
 		byte[] CloneSaveRam();
 
@@ -20,6 +21,11 @@
 
 		/// <summary>
 		/// Gets a value indicating whether or not SaveRAM has been modified since the last save
+		/// TODO: This is not the best interface. What defines a "save"? I suppose a Clone(), right? at least specify that here.
+		/// Clone() should probably take an optionthat says whether to clear the dirty flag.
+		/// And anyway, cores might not know if they can even track a functional dirty flag -- we should convey that fact somehow
+		/// (reminder: do that with flags, so we dont have to change the interface 10000 times)
+		/// Dirty SaveRAM can in principle be determined by the frontend in that case, but it could possibly be too slow for the file menu dropdown or other things
 		/// </summary>
 		bool SaveRamModified { get; }
 	}