From aab0dd582d23f1247f55e2102e0ee5d71fa0d798 Mon Sep 17 00:00:00 2001 From: YoshiRulz Date: Sun, 4 Apr 2021 14:16:41 +1000 Subject: [PATCH] Fix compliance with SA1142 (don't access ValueTuple fields as ItemN) --- src/BizHawk.Client.EmuHawk/config/PathConfig.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/BizHawk.Client.EmuHawk/config/PathConfig.cs b/src/BizHawk.Client.EmuHawk/config/PathConfig.cs index 293f274da6..ceb3dc7065 100644 --- a/src/BizHawk.Client.EmuHawk/config/PathConfig.cs +++ b/src/BizHawk.Client.EmuHawk/config/PathConfig.cs @@ -184,12 +184,12 @@ namespace BizHawk.Client.EmuHawk PathTabControl.TabPages.Clear(); var systems = _pathEntries.Select(e => e.System).Distinct() // group entries by "system" (intentionally using instance field here, not parameter) - .Select(sys => (sys, PathEntryCollection.GetDisplayNameFor(sys))) - .OrderBy(tuple => tuple.Item2) // sorted alphabetically by display name + .Select(sys => (SysGroup: sys, DisplayName: PathEntryCollection.GetDisplayNameFor(sys))) + .OrderBy(tuple => tuple.DisplayName) .ToList(); // add the Global tab first... const string idGlobal = "Global_NULL"; - systems.RemoveAll(tuple => tuple.Item1 == idGlobal); + systems.RemoveAll(tuple => tuple.SysGroup == idGlobal); AddTabPageForSystem(idGlobal, PathEntryCollection.GetDisplayNameFor(idGlobal)); // ...then continue with the others foreach (var (sys, dispName) in systems) AddTabPageForSystem(sys, dispName);