ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix 70bd081a93 

The entire call is skipped in release mode if you place it inside a Debug.Assert.
This commit is contained in:
CasualPokePlayer 2023-04-28 03:12:44 -07:00
parent a6deee765f
commit a2185d9ef0
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/BizHawk.Client.EmuHawk/Api/ApiManager.cs
View File

@ -63,7 +63,9 @@ namespace BizHawk.Client.EmuHawk
tuple => tuple =>
{ {
var instance = tuple.Ctor.Invoke(tuple.CtorTypes.Select(t => avail[t]).ToArray()); var instance = tuple.Ctor.Invoke(tuple.CtorTypes.Select(t => avail[t]).ToArray());
Debug.Assert(ServiceInjector.UpdateServices(serviceProvider, instance, mayCache: true)); var success = ServiceInjector.UpdateServices(serviceProvider, instance, mayCache: true);
Debug.Assert(success);
_ = success;
return (IExternalApi) instance; return (IExternalApi) instance;
})); }));
} }

4
src/BizHawk.Client.EmuHawk/tools/Lua/LuaLibraries.cs
View File

@ -66,7 +66,9 @@ namespace BizHawk.Client.EmuHawk
|| lib.GetCustomAttribute<LuaLibraryAttribute>(inherit: false)?.Released is not false) || lib.GetCustomAttribute<LuaLibraryAttribute>(inherit: false)?.Released is not false)
{ {
var instance = (LuaLibraryBase)Activator.CreateInstance(lib, this, _apiContainer, (Action<string>)LogToLuaConsole); var instance = (LuaLibraryBase)Activator.CreateInstance(lib, this, _apiContainer, (Action<string>)LogToLuaConsole);
Debug.Assert(ServiceInjector.UpdateServices(serviceProvider, instance, mayCache: true)); var updateSuccess = ServiceInjector.UpdateServices(serviceProvider, instance, mayCache: true);
Debug.Assert(updateSuccess);
_ = updateSuccess;
// TODO: make EmuHawk libraries have a base class with common properties such as this // TODO: make EmuHawk libraries have a base class with common properties such as this
// and inject them here // and inject them here