ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use `FrozenDictionary` for `Database` 

In a simple benchmark of calling `Database.CheckDatabase` 5x 10M times
(small edit on top of `BIZHAWKBUILD_RUN_ONLY_GAMEDB_INIT`),
median runtime was 46.1s w/ `Dictionary`, 44.0s w/ `FrozenDictionary`
(isolated to only swapping out the collection type used at the end of
`InitializeWork`, *not* a before/after comparison on this changeset,
also this was in Release config).
FWIW, the parse/load time increased from 0.38s to 0.74s
(again median of 5 runs in Release config, and this was a before/after
of this whole changeset).
This commit is contained in:
YoshiRulz 2024-11-08 02:25:17 +10:00
parent fe500ef61b
commit 9fd58a766a
No known key found for this signature in database
GPG Key ID: C4DE31C245353FB7
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/BizHawk.Emulation.Common/Database/Database.cs
View File

@ -1,5 +1,6 @@
#nullable disable
using System.Collections.Frozen;
using System.Collections.Generic;
using System.Diagnostics;
using System.IO;
@ -14,7 +15,9 @@ namespace BizHawk.Emulation.Common
{
public static class Database
{
private static readonly Dictionary<string, CompactGameInfo> DB = new();
private static readonly Dictionary<string, CompactGameInfo> _builder = new();
private static FrozenDictionary<string, CompactGameInfo> DB;
/// <summary>
/// blocks until the DB is done loading
@ -58,6 +61,7 @@ namespace BizHawk.Emulation.Common
}
}
/// <remarks>expensive, as it creates a new <see cref="FrozenDictionary{TKey,TValue}"/></remarks>
public static void SaveDatabaseEntry(CompactGameInfo gameInfo, string filename = "gamedb_user.txt")
{
var sb = new StringBuilder();
@ -89,7 +93,7 @@ namespace BizHawk.Emulation.Common
.Append(Environment.NewLine);
File.AppendAllText(Path.Combine(_userRoot, filename), sb.ToString());
DB[gameInfo.Hash] = gameInfo;
DB = DB.Append(new(gameInfo.Hash, gameInfo)).ToFrozenDictionary();
}
private static bool initialized = false;
@ -176,12 +180,12 @@ namespace BizHawk.Emulation.Common
{
Console.WriteLine($"WARNING: gamedb {path} contains entry for empty rom as \"{game.Name}\"!");
}
if (!silent && DB.TryGetValue(game.Hash, out var dupe))
if (!silent && _builder.TryGetValue(game.Hash, out var dupe))
{
Console.WriteLine("gamedb: Multiple hash entries {0}, duplicate detected on \"{1}\" and \"{2}\"", game.Hash, game.Name, dupe.Name);
}
DB[game.Hash] = game;
_builder[game.Hash] = game;
}
catch (FileNotFoundException e) when (e.Message.Contains("missing external game database"))
{
@ -196,6 +200,8 @@ namespace BizHawk.Emulation.Common
Util.DebugWriteLine($"Error parsing database entry: {line}");
}
}
DB = _builder.ToFrozenDictionary();
_builder.Clear();
}
public static void InitializeDatabase(string bundledRoot, string userRoot, bool silent)