From 9f0009b972c41b46265071ec69f997ff8a023623 Mon Sep 17 00:00:00 2001 From: YoshiRulz Date: Thu, 4 Jul 2024 06:31:44 +1000 Subject: [PATCH] Use `HashCode.Combine` instead of `string.GetHashCode` + XOR may write an Analyzer for this later --- src/BizHawk.Client.Common/input/InputEvent.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/BizHawk.Client.Common/input/InputEvent.cs b/src/BizHawk.Client.Common/input/InputEvent.cs index ffbb24ec93..bfb2017f92 100644 --- a/src/BizHawk.Client.Common/input/InputEvent.cs +++ b/src/BizHawk.Client.Common/input/InputEvent.cs @@ -61,7 +61,8 @@ namespace BizHawk.Client.Common public override readonly bool Equals(object? obj) => obj is not null && (LogicalButton) obj == this; //TODO safe type check? - public override readonly int GetHashCode() => Button.GetHashCode() ^ Modifiers.GetHashCode(); + public override readonly int GetHashCode() + => HashCode.Combine(Button, Modifiers); public override readonly string ToString() {