ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

bsnes - remove profile sync setting and related code

This commit is contained in:
adelikat 2017-06-12 20:56:16 -05:00
parent 971c6a9df6
commit 9eb2fcc34c
3 changed files with 2 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
BizHawk.Client.EmuHawk/config/ProfileConfig.cs
View File

@ -142,9 +142,6 @@ namespace BizHawk.Client.EmuHawk
// SNES
Global.Config.SNES_InSnes9x = false;
var snesSettings = GetSyncSettings<LibsnesCore, LibsnesCore.SnesSyncSettings>();
snesSettings.Profile = "Compatibility";
PutSyncSettings<LibsnesCore>(snesSettings);
// Genesis
var genesisSettings = GetSyncSettings<GPGX, GPGX.GPGXSyncSettings>();
@ -196,9 +193,6 @@ namespace BizHawk.Client.EmuHawk
// SNES
Global.Config.SNES_InSnes9x = false;
var snesSettings = GetSyncSettings<LibsnesCore, LibsnesCore.SnesSyncSettings>();
snesSettings.Profile = "Compatibility";
PutSyncSettings<LibsnesCore>(snesSettings);
// Genesis
var genesisSettings = GetSyncSettings<GPGX, GPGX.GPGXSyncSettings>();
@ -251,9 +245,6 @@ namespace BizHawk.Client.EmuHawk
// SNES
Global.Config.SNES_InSnes9x = false;
var snesSettings = GetSyncSettings<LibsnesCore, LibsnesCore.SnesSyncSettings>();
snesSettings.Profile = "Compatibility";
PutSyncSettings<LibsnesCore>(snesSettings);
// Genesis
var genesisSettings = GetSyncSettings<GPGX, GPGX.GPGXSyncSettings>();

5
BizHawk.Emulation.Cores/Consoles/Nintendo/SNES/LibsnesCore.ISettable.cs
View File

@ -28,8 +28,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.SNES
public bool PutSyncSettings(SnesSyncSettings o)
{
bool ret = o.Profile != _syncSettings.Profile
|| o.LeftPort != _syncSettings.LeftPort
bool ret = o.LeftPort != _syncSettings.LeftPort
|| o.RightPort != _syncSettings.RightPort
|| o.LimitAnalogChangeSensitivity != _syncSettings.LimitAnalogChangeSensitivity;
@ -67,8 +66,6 @@ namespace BizHawk.Emulation.Cores.Nintendo.SNES
public class SnesSyncSettings
{
public string Profile { get; set; } = "Compatibility"; // "Accuracy", and "Compatibility" are the other choicec, todo: make this an enum
public LibsnesControllerDeck.ControllerType LeftPort { get; set; } = LibsnesControllerDeck.ControllerType.Gamepad;
public LibsnesControllerDeck.ControllerType RightPort { get; set; } = LibsnesControllerDeck.ControllerType.Gamepad;

14
BizHawk.Emulation.Cores/Consoles/Nintendo/SNES/LibsnesCore.cs
View File

@ -199,19 +199,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.SNES
public string BoardName => "SGB";
}
public string CurrentProfile
{
get
{
// TODO: This logic will only work until Accuracy is ready, would we really want to override the user's choice of Accuracy with Compatibility?
if (_game.OptionValue("profile") == "Compatibility")
{
return "Compatibility";
}
return _syncSettings.Profile;
}
}
public string CurrentProfile => "Compatibility"; // We no longer support performance, and accuracy isn't worth the effort so we shall just hardcode this one
private LibsnesApi Api { get; }