From 9a45d883015cc3e6f7323fb5738b1d2877cdf306 Mon Sep 17 00:00:00 2001 From: RetroEdit <30182911+RetroEdit@users.noreply.github.com> Date: Tue, 7 Jul 2020 16:36:42 +0000 Subject: [PATCH] More concise FrameRate definition; comment tweaks (#2210) --- src/BizHawk.Client.Common/movie/bk2/Bk2Movie.cs | 9 +-------- src/BizHawk.Client.Common/movie/interfaces/IMovie.cs | 4 ++-- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/src/BizHawk.Client.Common/movie/bk2/Bk2Movie.cs b/src/BizHawk.Client.Common/movie/bk2/Bk2Movie.cs index f1f42d9c96..87ce097594 100644 --- a/src/BizHawk.Client.Common/movie/bk2/Bk2Movie.cs +++ b/src/BizHawk.Client.Common/movie/bk2/Bk2Movie.cs @@ -102,14 +102,7 @@ namespace BizHawk.Client.Common } } - public double FrameRate - { - get - { - var system = HeaderEntries[HeaderKeys.Platform]; - return PlatformFrameRates.GetFrameRate(system, IsPal); - } - } + public double FrameRate => PlatformFrameRates.GetFrameRate(SystemID, IsPal); public IStringLog GetLogEntries() => Log; diff --git a/src/BizHawk.Client.Common/movie/interfaces/IMovie.cs b/src/BizHawk.Client.Common/movie/interfaces/IMovie.cs index fdf4cd5ee8..c68baaead9 100644 --- a/src/BizHawk.Client.Common/movie/interfaces/IMovie.cs +++ b/src/BizHawk.Client.Common/movie/interfaces/IMovie.cs @@ -49,7 +49,7 @@ namespace BizHawk.Client.Common int FrameCount { get; } /// - /// Gets the actual length of the input log, should only be used by code that needs a the input log length + /// Gets the actual length of the input log, should only be used by code that needs the input log length /// specifically, not the frame count /// int InputLogLength { get; } @@ -99,7 +99,7 @@ namespace BizHawk.Client.Common string BoardName { get; set; } /// - /// Loads from the HawkFile the minimal amount of information needed to determine Header info and Movie length + /// Loads from the HawkFile the minimal amount of information needed to determine Header info and Movie length. /// This method is intended to be more performant than a full load /// bool PreLoadHeaderAndLength();