ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Default compare type to equal not NOTHING, fixes nes game genie codes generated through the cheat converter, and probably a lot of other platforms. And this is a better default, also silent failures are always bad

This commit is contained in:
adelikat 2017-02-25 15:08:20 -06:00
parent 22f9179ee7
commit 98a390b3c6
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
BizHawk.Client.Common/tools/Cheat.cs
View File

@ -237,8 +237,7 @@ namespace BizHawk.Client.Common
switch (_comparisonType) switch (_comparisonType)
{ {
default: default:
case COMPARISONTYPE.NONE: // This should never happen, but it's here just in case case COMPARISONTYPE.NONE: // This should never happen, but it's here just in case. adelikat: And yet it does! Cheat Code converter doesn't do this. Changing this to default to equal since 99.9999% of all cheats are going to be equals
break;
case COMPARISONTYPE.EQUAL: case COMPARISONTYPE.EQUAL:
if (_compare.Value == _watch.ValueNoFreeze) if (_compare.Value == _watch.ValueNoFreeze)
{ {