From 95cbbecb97cab0b07da0e0c021373234e564155c Mon Sep 17 00:00:00 2001 From: Morilli <35152647+Morilli@users.noreply.github.com> Date: Thu, 13 Feb 2025 16:49:16 +0100 Subject: [PATCH] harden TasView_QueryItemText exception handling by immediately throwing out the current movie. This should prevent this message box from coming up repeatedly, not providing any additional useful information and just blocking all other windows. should resolve #2332 --- .../tools/TAStudio/TAStudio.ListView.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.ListView.cs b/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.ListView.cs index d5f74ea092..0b49666a2b 100644 --- a/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.ListView.cs +++ b/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.ListView.cs @@ -357,7 +357,11 @@ namespace BizHawk.Client.EmuHawk catch (Exception ex) { text = ""; - DialogController.ShowMessageBox($"oops\n{ex}"); + DialogController.ShowMessageBox("Encountered unrecoverable error while drawing the input roll.\n" + + "The current movie will be closed without saving.\n" + + $"The exception was:\n\n{ex}", caption: "Failed to draw input roll"); + TastudioStopMovie(); + StartNewTasMovie(); } }