From 955e35b61ffc515f1fc564f733f1dbff62d67d0a Mon Sep 17 00:00:00 2001
From: Morilli <35152647+Morilli@users.noreply.github.com>
Date: Thu, 23 May 2024 06:04:37 +0200
Subject: [PATCH] simplify away FileInfo calls

---
 src/BizHawk.Client.Common/Api/Classes/MovieApi.cs    | 2 +-
 src/BizHawk.Client.Common/config/ConfigService.cs    | 2 +-
 src/BizHawk.Client.Common/tools/CheatList.cs         | 2 +-
 src/BizHawk.Client.EmuHawk/config/FirmwaresConfig.cs | 2 +-
 src/BizHawk.Common/HawkFile/HawkFile.cs              | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/BizHawk.Client.Common/Api/Classes/MovieApi.cs b/src/BizHawk.Client.Common/Api/Classes/MovieApi.cs
index 972c6d8391..04d75a2f1d 100644
--- a/src/BizHawk.Client.Common/Api/Classes/MovieApi.cs
+++ b/src/BizHawk.Client.Common/Api/Classes/MovieApi.cs
@@ -66,7 +66,7 @@ namespace BizHawk.Client.Common
 			if (!string.IsNullOrEmpty(filename))
 			{
 				filename += $".{_movieSession.Movie.PreferredExtension}";
-				if (new FileInfo(filename).Exists)
+				if (File.Exists(filename))
 				{
 					LogCallback($"File {filename} already exists, will not overwrite");
 					return;
diff --git a/src/BizHawk.Client.Common/config/ConfigService.cs b/src/BizHawk.Client.Common/config/ConfigService.cs
index 310790ac32..b3f39ec966 100644
--- a/src/BizHawk.Client.Common/config/ConfigService.cs
+++ b/src/BizHawk.Client.Common/config/ConfigService.cs
@@ -41,7 +41,7 @@ namespace BizHawk.Client.Common
 			const string MSGFMT_PRE_2_3_3 = "Your config file ({0}) is corrupted, or is from an older version of EmuHawk, predating 2.3.3 (this is {1}). It may fail to load.";
 			const string MSGFMT_PRE_2_5 = "Your config file ({0}) is corrupted, or is from an older version of EmuHawk, predating 2.5 (this is {1}). It may fail to load.";
 
-			if (!new FileInfo(filepath).Exists)
+			if (!File.Exists(filepath))
 			{
 				msg = null;
 				return true;
diff --git a/src/BizHawk.Client.Common/tools/CheatList.cs b/src/BizHawk.Client.Common/tools/CheatList.cs
index 0d92d13823..cf4fcbba9e 100644
--- a/src/BizHawk.Client.Common/tools/CheatList.cs
+++ b/src/BizHawk.Client.Common/tools/CheatList.cs
@@ -242,7 +242,7 @@ namespace BizHawk.Client.Common
 				}
 				else if (!_cheatList.Any() && !string.IsNullOrWhiteSpace(CurrentFileName))
 				{
-					new FileInfo(CurrentFileName).Delete();
+					File.Delete(CurrentFileName);
 					_config.Recent.Remove(CurrentFileName);
 				}
 			}
diff --git a/src/BizHawk.Client.EmuHawk/config/FirmwaresConfig.cs b/src/BizHawk.Client.EmuHawk/config/FirmwaresConfig.cs
index 3ab096b0cb..4cdc019e29 100644
--- a/src/BizHawk.Client.EmuHawk/config/FirmwaresConfig.cs
+++ b/src/BizHawk.Client.EmuHawk/config/FirmwaresConfig.cs
@@ -591,7 +591,7 @@ namespace BizHawk.Client.EmuHawk
 				}
 
 				string target = Path.Combine(basePath, fi.Name);
-				if (new FileInfo(target).Exists)
+				if (File.Exists(target))
 				{
 					// compare the files, if they're the same. don't do anything
 					if (File.ReadAllBytes(target).SequenceEqual(File.ReadAllBytes(f)))
diff --git a/src/BizHawk.Common/HawkFile/HawkFile.cs b/src/BizHawk.Common/HawkFile/HawkFile.cs
index ac544d5331..fffdeed224 100644
--- a/src/BizHawk.Common/HawkFile/HawkFile.cs
+++ b/src/BizHawk.Common/HawkFile/HawkFile.cs
@@ -90,7 +90,7 @@ namespace BizHawk.Common
 			var split1 = SplitArchiveMemberPath(path);
 			if (split1 != null) (path, autobind) = split1.Value;
 			FullPathWithoutMember = path;
-			Exists = _rootExists = !string.IsNullOrEmpty(path) && new FileInfo(path).Exists;
+			Exists = _rootExists = File.Exists(path);
 			if (!_rootExists) return;
 
 			if (DearchivalMethod != null && allowArchives)