Tastudio - try to sort out when to fully redraw tastudio vs update row count

This commit is contained in:
adelikat 2020-04-29 19:39:18 -05:00
parent 9203f56eca
commit 92db6b8b64
4 changed files with 18 additions and 20 deletions

View File

@ -87,7 +87,7 @@ namespace BizHawk.Client.EmuHawk
TasView.AllColumns.Clear(); TasView.AllColumns.Clear();
StartNewTasMovie(); StartNewTasMovie();
SetUpColumns(); SetUpColumns();
RefreshTasView(); TasView.Refresh();
} }
else else
{ {

View File

@ -424,10 +424,8 @@ namespace BizHawk.Client.EmuHawk
private void TasView_ColumnRightClick(object sender, InputRoll.ColumnClickEventArgs e) private void TasView_ColumnRightClick(object sender, InputRoll.ColumnClickEventArgs e)
{ {
e.Column.Emphasis ^= true; e.Column.Emphasis ^= true;
UpdateAutoFire(e.Column.Name, e.Column.Emphasis); UpdateAutoFire(e.Column.Name, e.Column.Emphasis);
TasView.Refresh();
RefreshTasView();
} }
private void UpdateAutoFire() private void UpdateAutoFire()
@ -565,7 +563,7 @@ namespace BizHawk.Client.EmuHawk
{ {
_extraAxisRows.Clear(); _extraAxisRows.Clear();
AxisEditRow = -1; AxisEditRow = -1;
RefreshTasView(); SetTasViewRowCount();
} }
else else
{ {
@ -573,7 +571,7 @@ namespace BizHawk.Client.EmuHawk
{ {
_extraAxisRows.Clear(); _extraAxisRows.Clear();
AxisEditRow = frame; AxisEditRow = frame;
RefreshTasView(); SetTasViewRowCount();
} }
_axisEditYPos = e.Y; _axisEditYPos = e.Y;
@ -820,7 +818,7 @@ namespace BizHawk.Client.EmuHawk
// if a loaded branch log is shorter than selection, keep selection until you attempt to call context menu // if a loaded branch log is shorter than selection, keep selection until you attempt to call context menu
// you might need it when you load again the branch where this frame exists // you might need it when you load again the branch where this frame exists
TasView.DeselectAll(); TasView.DeselectAll();
RefreshTasView(); SetTasViewRowCount();
} }
else else
{ {
@ -1176,7 +1174,7 @@ namespace BizHawk.Client.EmuHawk
TasView.MakeIndexVisible(TasView.CurrentCell.RowIndex.Value); // todo: limit scrolling speed TasView.MakeIndexVisible(TasView.CurrentCell.RowIndex.Value); // todo: limit scrolling speed
} }
RefreshTasView(); SetTasViewRowCount();
} }
private void TasView_MouseMove(object sender, MouseEventArgs e) private void TasView_MouseMove(object sender, MouseEventArgs e)

View File

@ -388,13 +388,13 @@ namespace BizHawk.Client.EmuHawk
private void DeselectMenuItem_Click(object sender, EventArgs e) private void DeselectMenuItem_Click(object sender, EventArgs e)
{ {
TasView.DeselectAll(); TasView.DeselectAll();
RefreshTasView(); TasView.Refresh();
} }
private void SelectAllMenuItem_Click(object sender, EventArgs e) private void SelectAllMenuItem_Click(object sender, EventArgs e)
{ {
TasView.SelectAll(); TasView.SelectAll();
RefreshTasView(); TasView.Refresh();
} }
private void SelectBetweenMarkersMenuItem_Click(object sender, EventArgs e) private void SelectBetweenMarkersMenuItem_Click(object sender, EventArgs e)
@ -413,7 +413,7 @@ namespace BizHawk.Client.EmuHawk
} }
SetSplicer(); SetSplicer();
RefreshTasView(); TasView.Refresh();
} }
} }
@ -426,7 +426,7 @@ namespace BizHawk.Client.EmuHawk
} }
SetSplicer(); SetSplicer();
RefreshTasView(); TasView.Refresh();
} }
private void CopyMenuItem_Click(object sender, EventArgs e) private void CopyMenuItem_Click(object sender, EventArgs e)
@ -1303,7 +1303,7 @@ namespace BizHawk.Client.EmuHawk
CurrentTasMovie.FlagChanges(); CurrentTasMovie.FlagChanges();
TasView.AllColumns.ColumnsChanged(); TasView.AllColumns.ColumnsChanged();
RefreshTasView(); TasView.Refresh();
}; };
ColumnsSubMenu.DropDownItems.Add(item); ColumnsSubMenu.DropDownItems.Add(item);
@ -1330,7 +1330,7 @@ namespace BizHawk.Client.EmuHawk
CurrentTasMovie.FlagChanges(); CurrentTasMovie.FlagChanges();
TasView.AllColumns.ColumnsChanged(); TasView.AllColumns.ColumnsChanged();
RefreshTasView(); TasView.Refresh();
}; };
ColumnsSubMenu.DropDownItems.Add(item); ColumnsSubMenu.DropDownItems.Add(item);
@ -1345,9 +1345,9 @@ namespace BizHawk.Client.EmuHawk
private void RestoreDefaults() private void RestoreDefaults()
{ {
TasView.AllColumns.Clear(); TasView.AllColumns.Clear();
SetUpColumns(); SetUpColumns();
RefreshTasView(); TasView.Refresh();
CurrentTasMovie.FlagChanges(); CurrentTasMovie.FlagChanges();
MainVertialSplit.SplitterDistance = _defaultMainSplitDistance; MainVertialSplit.SplitterDistance = _defaultMainSplitDistance;
BranchesMarkersSplit.SplitterDistance = _defaultBranchMarkerSplitDistance; BranchesMarkersSplit.SplitterDistance = _defaultBranchMarkerSplitDistance;
@ -1402,7 +1402,7 @@ namespace BizHawk.Client.EmuHawk
private void CancelSeekContextMenuItem_Click(object sender, EventArgs e) private void CancelSeekContextMenuItem_Click(object sender, EventArgs e)
{ {
MainForm.PauseOnFrame = null; MainForm.PauseOnFrame = null;
RefreshTasView(); TasView.Refresh();
} }
private void BranchContextMenuItem_Click(object sender, EventArgs e) private void BranchContextMenuItem_Click(object sender, EventArgs e)

View File

@ -921,7 +921,7 @@ namespace BizHawk.Client.EmuHawk
if (refreshTasView) if (refreshTasView)
{ {
RefreshTasView(); SetTasViewRowCount();
} }
MarkerControl?.UpdateValues(); MarkerControl?.UpdateValues();
@ -937,7 +937,7 @@ namespace BizHawk.Client.EmuHawk
} }
} }
private void RefreshTasView() private void SetTasViewRowCount()
{ {
TasView.RowCount = CurrentTasMovie.InputLogLength + 1; TasView.RowCount = CurrentTasMovie.InputLogLength + 1;
_lastRefresh = Emulator.Frame; _lastRefresh = Emulator.Frame;