From 920682688bf66f3b4b0da4634a7e27c7424dd05c Mon Sep 17 00:00:00 2001 From: CasualPokePlayer <50538166+CasualPokePlayer@users.noreply.github.com> Date: Mon, 5 Dec 2022 18:23:11 -0800 Subject: [PATCH] deprecate lua bit functions which have direct operator counterparts in new lua --- .../lua/LuaHelperLibs/BitLuaLibrary.cs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/BizHawk.Client.Common/lua/LuaHelperLibs/BitLuaLibrary.cs b/src/BizHawk.Client.Common/lua/LuaHelperLibs/BitLuaLibrary.cs index afd57927b2..8075dedc18 100644 --- a/src/BizHawk.Client.Common/lua/LuaHelperLibs/BitLuaLibrary.cs +++ b/src/BizHawk.Client.Common/lua/LuaHelperLibs/BitLuaLibrary.cs @@ -13,6 +13,7 @@ namespace BizHawk.Client.Common public override string Name => "bit"; + [LuaDeprecatedMethod] [LuaMethodExample("local uibitban = bit.band( 1000, 4 );")] [LuaMethod("band", "Bitwise AND of 'val' against 'amt'")] public static uint Band(uint val, uint amt) @@ -20,6 +21,7 @@ namespace BizHawk.Client.Common return val & amt; } + [LuaDeprecatedMethod] [LuaMethodExample("local uibitbno = bit.bnot( 1000 );")] [LuaMethod("bnot", "Bitwise NOT of 'val'")] public static uint Bnot(uint val) @@ -27,6 +29,7 @@ namespace BizHawk.Client.Common return ~val; } + [LuaDeprecatedMethod] [LuaMethodExample("local uibitbor = bit.bor( 1000, 4 );")] [LuaMethod("bor", "Bitwise OR of 'val' against 'amt'")] public static uint Bor(uint val, uint amt) @@ -34,6 +37,7 @@ namespace BizHawk.Client.Common return val | amt; } + [LuaDeprecatedMethod] [LuaMethodExample("local uibitbxo = bit.bxor( 1000, 4 );")] [LuaMethod("bxor", "Bitwise XOR of 'val' against 'amt'")] public static uint Bxor(uint val, uint amt) @@ -41,6 +45,7 @@ namespace BizHawk.Client.Common return val ^ amt; } + [LuaDeprecatedMethod] [LuaMethodExample("local uibitlsh = bit.lshift( 1000, 4 );")] [LuaMethod("lshift", "Logical shift left of 'val' by 'amt' bits")] public static uint Lshift(uint val, int amt) @@ -62,6 +67,7 @@ namespace BizHawk.Client.Common return (val >> amt) | (val << (32 - amt)); } + [LuaDeprecatedMethod] [LuaMethodExample("local uibitrsh = bit.rshift( 1000, 4 );")] [LuaMethod("rshift", "Logical shift right of 'val' by 'amt' bits")] public static uint Rshift(uint val, int amt)