From 8e7467f77b4bbb8d54feaf4a6264d82e5f48915b Mon Sep 17 00:00:00 2001 From: alyosha-tas Date: Fri, 17 Apr 2020 18:52:45 -0400 Subject: [PATCH] O2Hawk: fix collision detection --- BizHawk.Emulation.Cores/Consoles/Magnavox/Odyssey2/PPU.cs | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/BizHawk.Emulation.Cores/Consoles/Magnavox/Odyssey2/PPU.cs b/BizHawk.Emulation.Cores/Consoles/Magnavox/Odyssey2/PPU.cs index 5c71881871..8ed1301460 100644 --- a/BizHawk.Emulation.Cores/Consoles/Magnavox/Odyssey2/PPU.cs +++ b/BizHawk.Emulation.Cores/Consoles/Magnavox/Odyssey2/PPU.cs @@ -98,8 +98,11 @@ namespace BizHawk.Emulation.Cores.Consoles.O2Hawk ret |= VDC_col_ret[i]; } } - - //Console.WriteLine("col: " + ret + " " + Core.cpu.TotalExecutedCycles); + + // register is reset when read + for (int i = 0; i < 8; i++) { VDC_col_ret[i] = 0; } + + //Console.WriteLine("col: " + ret + " " + LY + " " + Core.cpu.TotalExecutedCycles); } else if (addr == 0xA3) { @@ -346,7 +349,6 @@ namespace BizHawk.Emulation.Cores.Consoles.O2Hawk Core.in_vblank = false; Core.cpu.T1 = false; if (Core.is_pal) { Core.cpu.IRQPending = false; } - for (int i = 0; i < 8; i++) { VDC_col_ret[i] = 0; } LY_ret = 0; }