From 8c9587e00bb34d0c08b0104eee209bb23405cec4 Mon Sep 17 00:00:00 2001 From: Morilli <35152647+Morilli@users.noreply.github.com> Date: Thu, 22 Aug 2024 23:13:43 +0200 Subject: [PATCH] Fix BootGodDB lookup being completely broken in quicknes - closes #3703 Presumably broken since e38726db50186caa52aaac3b4e5b2cf7bf0be826. --- src/BizHawk.Emulation.Cores/Consoles/Nintendo/NES/BootGodDB.cs | 2 +- .../Consoles/Nintendo/QuickNES/QuickNES.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/BizHawk.Emulation.Cores/Consoles/Nintendo/NES/BootGodDB.cs b/src/BizHawk.Emulation.Cores/Consoles/Nintendo/NES/BootGodDB.cs index 969c95f157..b71f28f367 100644 --- a/src/BizHawk.Emulation.Cores/Consoles/Nintendo/NES/BootGodDB.cs +++ b/src/BizHawk.Emulation.Cores/Consoles/Nintendo/NES/BootGodDB.cs @@ -136,7 +136,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.NES { currCart = new CartInfo(); currCart.System = xmlReader.GetAttribute("system"); - currCart.Sha1 = $"SHA1:{xmlReader.GetAttribute("sha1")}"; + currCart.Sha1 = $"{SHA1Checksum.PREFIX}:{xmlReader.GetAttribute("sha1")}"; currCart.Name = currName; state = 2; } diff --git a/src/BizHawk.Emulation.Cores/Consoles/Nintendo/QuickNES/QuickNES.cs b/src/BizHawk.Emulation.Cores/Consoles/Nintendo/QuickNES/QuickNES.cs index c817c5f3b6..78e3e52481 100644 --- a/src/BizHawk.Emulation.Cores/Consoles/Nintendo/QuickNES/QuickNES.cs +++ b/src/BizHawk.Emulation.Cores/Consoles/Nintendo/QuickNES/QuickNES.cs @@ -285,7 +285,7 @@ namespace BizHawk.Emulation.Cores.Consoles.Nintendo.QuickNES throw new UnsupportedGameException("Game known to not be playable in this core"); } - sha1 = "sha1:" + sha1; // huh? + sha1 = $"{SHA1Checksum.PREFIX}:{sha1}"; var carts = BootGodDb.Identify(sha1); if (carts.Count > 0)