From 867b560a1d3c4dd97ae71c4f117d943e24e6b737 Mon Sep 17 00:00:00 2001 From: YoshiRulz Date: Tue, 2 Jul 2024 05:32:19 +1000 Subject: [PATCH] Fix BHI3300 being raised twice for offending accessors --- .../FeatureNotImplementedAnalyzer.cs | 2 ++ References/BizHawk.Analyzer.dll | Bin 33280 -> 33280 bytes 2 files changed, 2 insertions(+) diff --git a/ExternalProjects/BizHawk.Analyzer/FeatureNotImplementedAnalyzer.cs b/ExternalProjects/BizHawk.Analyzer/FeatureNotImplementedAnalyzer.cs index ffaedb03cb..fbdc535037 100644 --- a/ExternalProjects/BizHawk.Analyzer/FeatureNotImplementedAnalyzer.cs +++ b/ExternalProjects/BizHawk.Analyzer/FeatureNotImplementedAnalyzer.cs @@ -88,7 +88,9 @@ public sealed class FeatureNotImplementedAnalyzer : DiagnosticAnalyzer else { if (IncludesFNIAttribute(pds.AttributeLists)) Wat(pds.GetLocation()); +#if false // accessors will be checked separately else foreach (var accessor in pds.AccessorList!.Accessors) CheckAccessor(accessor); +#endif } break; } diff --git a/References/BizHawk.Analyzer.dll b/References/BizHawk.Analyzer.dll index b60ebbc2e0fdae52afea044a7faa6649b70547fe..77400aed1d07faab0ed0bc1be93cd8b67a9e32c2 100644 GIT binary patch delta 8838 zcmai33w#viwLjm??#w=BXEU?Ac@jtngw10yA>ok-H4zX{5x7=R#79W5M%3jM? z!3PDZ>4<_-D+aarxRpk$c+nEE7Oy|Gcx~0IR%!Gq_O?KaR_|53|L@EuL3@8SKk}dR z_@DEg?|hHV4(Sa_dV_M?EuM$YeQjgc<{`@HZCww|HQ&CIXcpn;UZVYKS82r9Ph>#% z!0~;jRH=3@5~GyatDGCe`hxH_c}D+3SLECi|AlNYQ~a)WyHhgv03q(-GOWb+eQYDX&w2_;&os5YI9 zl{<5SJH(~VUxJf>)y4}*_BSJ;942RY=qZtK-VT+749%ZBALAuan&zBtjttC&7M};G zbQYUcnyWfH%rWMm=dbGKp!1HIpMN2EBhv}AE3Ok&DJM0|L|Z=JF~XHOXiUJZ1a)cg zOPsU9XO|2nQIn^G5U?pXJ_$kxrXzy7W91Y_21$x?eXY#Czaglc*?;UREXBpc+*b zzT_eZA%F4;JR%<36aRtJWaU?12{rNR9|FE=&6jM4@{X#V)aJ;!p9w8*3kDG*bBE>L zlf25=U{%?RVO@clh=7*78glX)r`IY=T?X?dX{K}QFM?}Q5%!VBbV$EabD$gy%dFm2Iroy*Edqh(pxHQOUY zQs0^hZ*$Bwg1Lr8d^X76o-9*jXW}4f4Su8rQ*Ld4@&=$C$*xf(-YLh5+R^w12qP1r zayxc17R8pbVpW0UjWAxm{3gkcgiVTg{_oyVDFgX+>uuwxgBDacUgTNExE7%Fua?0W%akp?;n1pn#5fnNZtX! z-FUgYAMSLP<`;0FD zSa`Ik?7vE&2leDn@mO{emBmXXvl=T`^vyG@=y6<+T0+gQ5(Uv{RFCs&t#g_SMy1xv z@Z5Y_lAI}}*;1107PLif{9Xv_rXZWL7H8d)s8rBPj+j3XvFslsBo{<^u2vwcy!?

ldC)`tL@`9%KH`i<91VhkPh%l>c;h3`EAjD!)eDUFxz8%-_d)MKN+CCK!)Tlu zY~pUGyf9I;3$AEh@_sz-8=1Fk11icc(>&+e!lE<3<^Sa=euPxYO^hdw)dP6gzU;~N zxhLCi`{Ns&mkKK*r>1dt!92%TRQc`UKRzYBGqY&uHWgy|xl0TDAQK_swYoM>Y zVOmB7{VOp68xo(8J1>!gm@&nIJ$Cq}<-+>!aBx?N~4cU%5pA^+z?0(`5 ze8j}d5qZi?AHq1nu+Wna%ewUSB^as7yB<60)DMHaEw~f#`Q~oAfs?RuNadt-0Z|!t z#((2EyAbmEE0(oi`-A0JOqy6vR4x4%oKII`KjgqxHtm8L*b}r0`V{BgA){g_n?~Um zlcYu2=fh4x@i39+G!&=A7-w&BS?cT9K})0F=o^McpNlsPn|cb$ay6PM=6P+}lPl$m zVGqzzFaxx~IA#ZEA7q<8%P-5d=|RRELw`n?)7IG0$#vAg=oN2=n zq4x@oYUo&j3>oWWh7~uQ&uL%cguh`t$PwL~qdhV-CqS2?m;il@{@C;f*NaK_4LjqU zyO_0_ZIv9|0yODsaa6Nu7t3oR6LZir=B&nO0lGW3GN#eq;8n2z{lQonv+3)+vYu;7 z-Vma~nL2!GszOYoE2x|tyE9l$w+3$p-e>+WI4AA%9`wvfKkkt@pK&X&mPUKF1WPHb zbp>l_jL|R8Ne^RwJ~NLozQ(wMqkbCQ0{-nmiI>_Emq<)ec|>2CA(b4ux`cRTp6F^<)Cd`s>@p{}=1q#ji64c3V_)cb?u=q~kV z!CYFeJ_6i8PX{&X4m}6_obf#G3y`;qe`n?^;0WdzXdI$KD zkm&L?W=0wR)*AjVrv7QbJvW6!7DW!e*+mSU7L0JUzf;@@(r(t= zQ4QMTYFurIK4gt^o<%0nNEzrRHL0F8hb~r5Gfa8}SFIf4V`ZEXruSHLljhJzuEtY& zcx2H9Vccg|%1baiS(}!)8V?(xXIXQn5~X)ob4QKR`1oL4l$u&mB!RnCF(its991ij6k zn|$v@);a%MUes`dQOo@nmfWI`hc}gk|U%h(Np-Gl^uDNjvC*iH?!L7;;3;3ea4y_*hDneWmYO5 z8%^{mYwi%uw3juP*-X!8nR19`Dj6r^T;G`#XRVWVV}vtPG(D?UDxVpXX;oJH2s4~Q z*7(7|sWgPOPI`hKFs4#*!=UdhinAtt9~<&d0ry8xQSLvNz4*(7QqGZz;#x@+GzVWH z1YHpM=V6jlE9hMhC2mWQ@0@($d| zxZC+vRavT6$@eu;7fJhz%JjlHv>oySiUMosu=1CJRkWMNhHoIryn}{NB=#hYpxHcS-$j0pZjblAO?z>Lzf8SihWQCBOSC5;AB-NOFO*q1 zu%yI~V=q&MQWqO9{AwtAj;O}KbAhvQEUW30=yNoYhpcCNJ=^QE_E(H0qLyPDl#ZO0 zqEyifk5Q>|B6z)M7PF%_h$$R9g(P!^@{oB9MLd8Jn|b(NC6({HPn^qh-A(6(pB0w) zGWxnGRXsUoxvOkp=ZC7jY3^kWBgo$rN9ZOm~s`r^uJe9JM$WRRD`0F z)XgLprCn`_Ef7mp;gdznsb<92W@?SPQQWMh)urOEMp|91%E2~@%c3`_w{z20tJ8B| z7a0t{O>Gb>(2pZ@P4q!^2Ya`Rk96{ zQbq3PrHY(DMoFNEc4e_X+iQu(V{^T$!CdHFt-c*yAU29!+8Q+@2!JkIGK8Yc(Jh`kMr4aF>o@qBE@7} z)plqGCv9a*D_dG=F?r24wzo5OvR7X1cBm8HYI7soyV>5&_HNkEH+QjpH{*Wx9-!eV zT4Nr-OOz9#1GJpd=8Np^qv5dkvAvJ&A3z=xKEhsANUthnlqzJDN61c;W>HR{j5%e@ zDPvBP;EAz)GTSG^o=Tf79M;0_R(7|tyOqN_+0x0DPPS}demC2@+1@Q=+xK&Z17b04 zHV=rkupAJbz&^J0v89hKs?oStcEjrM*evs$qY{oXqyg zY@fpX%h}t?QLXH4WpA48or>&Jry~2*3C;(QW#&%iY~T#3ZYFgzshdgNOzLLR0Ur1O zTMn@0c`(O>`#7qPqx!%J!Xi`mF^5!Hv{2=g1k0)_C#I^BqpCb%ym=oJE=jSwjIoKa znZue{p3K;%v;8nz$SXO*D+exNxs>H5mZx|(rQpcm zg}{l>PR9N0?)A#D4zoqzYwC$mi6&EwfIKGL%$Cd9(!z3^Cixl0oow09-d>j9XZbM8 zLYLV}8JmHr6QRp>nYx8d8C@p2mn}Ql(#v?5QTRC6Cpk^N;YifXmKMeg<4(q2#uC5e zydRKAK}LMXIS~^4W@QvzP2JV_Ec%S@5Ie+U;$`ulLRTu4SCw~_K4q5rqI$FEVb2qu zmpmsus<+B}rE_lh2qNCP#H)yfVNNE>b&op1bF1e)&k*l~ZFtE?)3-Ul7+YSk)w@lTf2DbFtM&if<2@!{1Cy`cfaimb z7#9)uII(e;mGsb7)i zlIpxV>s4pZ>?J+J<|GPo{^P#WwoO^^^O^s8&%|-|^v3zlf~(@<66eONCe3eGOtaYZ z=)%5Ui`mx*Yqg&gVP_UunT}A6P=sqN9!lPTurk*eIYPv&IbtZm6x4N7Q503N((mdq zD}4xNwS;`glzz(@vbZGmu1|;acXs+iZwWyF+8NQL8&>)j80}2V&J@_0;+U233Lhiq zu`{LpCS-*MG8|iloxb1BjN~+#&^P#j66z22mIx7%l}u7JHw{v|dEknWkK;=vrgyq= zoLRD1@ah7^I-f5tP4${3*(RiWi>*vT(-k|tQQ_E)JiF~y`X?r-Ksz%7v$N9M+1usO z?95hwiK5t~(fJW2bM#F#eK+oD^zm;gpXu zZZSx;Gxysw?ev!7AsQwNO{UoDe0}x2)Qr$TG3}@&q$~Z?veUaUGdsN}ALFdDJFrYo zK;4Ufa!u{@Gl3FbT~uo#AxxQCUU7R7me$Vf!6pD%k3q*%PC%wWNBdLxOH!zqbGZr9 z&s6F`JN;`Orpr!ux!xC1ne14Hoql=1*u~v>h9}9%Inj&RL@y3DIlU3#+&(!{SC-(0 zr+)1vY-&>th#@oeJktchP9L_@N9^>U?euX>AD#UN%cpkw3p@Q4){l3LmGR38vwMs+ z-n{8AxVo=oEt$|a7CckS8+bmBi6123;Ff$#HZJqlfFb=Ack-)Zyp+zaq?KuR+qwm3 z;$3+xhv;&zZLmAg-Af?tbrQ+q=rgwN$@Vj2Wt-_-nruqR7H4Zu^grDrg>B0PB}V80 zJ2N)Bu)Hf9?93$Dj!ZK)ygOq#!OWk7CD^vd?aZfEhNqlaSFHQxxS87ic-h4d5oY3u zZ#U5q&Nu_6=a|~->BS?OLpxc8f{dp+J(*IM7Uu%@AHQR~9`D;iqs$Bkb! zc0x|EE~WC0(Vt_5-U;Bf0qej4&q<{=Dm4>&tn^XQ HRipnO8j1@D delta 8966 zcmai33w#vS)jxM;XJ#L>lg#WRZ%7CUn@u(*_``c-kwJnYCpdhU;*IQ0{}o!g?YXyTX>TeW!7_0C9OuSQI zmF712Nb)z)K(&Xmgtpm8xgC|exqI8U%*Dz_Xfn$_-E$=>JTBc;kfOW7-vDs7RrcR! zH!zTS!0`&3XKrx*w5Sn{3T#QPe8KNh3Qo&G08fz!*%-|Mpo?uQ(I6yvgMw(lMc*W| z&b5avGe2=vAr`1FVX#kC)H8E}`xk7v`K~*&+ATZ6S7W{~7AXfE;f0)Dgy4}4IdB~( zqd6H+A{#pKzSCYH+ru{@^PVVQl#o!DWP;~($8KO8n|^?aiRrRyhC{o$LD z4!4>+_3X$xB<1jWL>}B9Xyd942)xe%^|NYH!Oxu}9IBkY;Zy z<+NS5hm!I$adX?bsnc-!0~ z(pog(CART{RQVGeccgKhtnxXFuHb8M=#I*h7LOCcJWkzNIggR;G|uDcs=UMEtFU6` zQFXQQ8B2f-VwGQ5G@d@@(R8h1kATivxQk~`&=V?mSo}85C+dl9*i2S&izU2`3w2$m zDf75>cjfCCEr^})j;>*}6^hl1db7vliNw%%OoQkg@ook@I1v>NOn^OTKqE)^dx(Z7 zzOSCZcAnL1cmv%?S0hVP=!k7KC&@}1$^QMm37ZekclU6PIq}ET?*f2-scUCIs3Zm zk##w2a$h<81A2^x_{1A18x4Ua;SxsneY9s|D{^}j-V<}KuTaLz6fYk$;+s8k@4V_; zC|f7e4EQr9+>Hh~QM{>b0XL3e2VNUCS!qp7!s&~ft@dZIyUlI>34t+358Zx@uDvUC&Ph*@c_!!?L$xvA@CqR3tUL_Au&FokOk%V9fQ0}2|t97){9tK zAd6cT;P#~P296$XK?y9w5<+5fK1=a>y-I+#WUJ{;i63--a{QpT)^dtB-DNO;;9(>> zW@0p9(=5bL@X{Ty_>xEKzj|=n__eV9Dr_ZQf*1r}RJzoL?{a*@hBA=sK=O)8JehzD z-XV;Saphyk2l1u%WArGrThDyte}a4)-ocDdYDFQQ4V=_R%=0OswEd{^CWRlx$AdXZ ztzB4Ae4Fac%G9*!U(-J|MvpFd3DD`qv-4AA4SW3f+O6a3FdTty^Pbe8XKa{}`{9k$ z;Mddtc}#dSC2ibSwi{RH4B6%I0sdq`VG~}N@xJ~HMXiuBvJ>f?;yZyu5Z?)IYk62B z5Ww;0Z$c{^ZMfUfwiSC6Dt5HtfufF@Po)(vv0g=ZCtL5HKrVWYS?SMF;Ywgi_;Dmc z%9c#blrL?;i5fddNjvf2NR0G~jneLZiK3gOi@Ebp;m!RAU8d^G`OFe5i;a%S=x&c14G~lIV zjwMJt;i$~Do7h?7PKfHbSa@CIl3USBhAG-3E+;67XAJ{RVPpdi2Pwo8gojA92E)m) z64N{321<5>@H2DnxV%V_k2}{=%1*K$OyYsI5U!v&e<9)s_EROIp(hI56&AsEVnENzkxtBEaNz;X>!I$ieY{1Jz zZ}dz{G~j1sb1!Cc!ZW_zJ{g{Nb^Dy~zPj6Iz_{e;{gX1^Vk~5SnKdgCVzZ$Ma=|o? zxN_l6*8t*!+6%6_s9h4Iy67Pr$Hj!Z5sRVF_OdGr669aGiea)kLf1vdlYKH-o+W&p za6Ne)@V<=pKX7sUj=`~oV+3+NoOxQ~STiQ{4Ze}k#jq6JMpEuqxMggN{wLz+ zgjY#`hoYC+RBmZk{lLg3k-XQvXf_DrZQ;B#M2D7CEuZ!A{V*DaozVXaS~?SOWaHLzvz{y zd)VS&gKLI4e`4CTb5s%dn+(9R5TVH8xP@wimBjHpjQ@Q{Tu*Y3K1Y?{@iBf9{9@G4 zJTft@Vvef7_G}*6#J>;cBUeAs;{FaRR2S?g&dRF7L5rih^qjQF994tT9Ls)*(2U$; zc!%;>e->KQ1o(hB%R3Q1v^c6+hqOuD(yG~jQsS(d4frl`mY)GF7Ds*_cy83s{ArFG zYw*I90FPzad!gFm$leEC#94X#@DOoU9=x~nxZmCIe)1;V*izzp;5nsBO@_v}?m1c8ur|(JE_|#O!`pE#Cj4D3f#i^t;eJtY zm%?>%P897CcNu&hXRAfSJq4~Sv`m+Y>Fx@6ia4vmmGC@qR%w;+YTVKZC)7%~_p;H_ zE{6w*>x3Yi;JzI87LDqr!6U?V!iTt|$TYCws}sOVQ3Z*_St+U@nYd1Tg`H5V;IDD+ z1mwBD0csid>x4I0p8E<25@-2ULup(W6ehT--&w$6`+=sZrnJ^3gdK~ea1+~O=!jo`HodtCjqq=WGJ#kz& z!Tn9ZUk$7;29^H*PVe;c&wN@m01-OzcMJyjyTWJ$b09A%#h=t~0FbTC6g6rJ-1b+YQCp>7j=VwQb3(59s=m9Q2DQrotgI=WT z!HZY~!@|VWTVX$xC2R$5c{ij(mhUi3gx|=|!v$ek>dPp3&-EJ8wVsoR!>+@Kzw^8a z2iX+qT^L|odz{VDK0-;0d>H9By=Q@m3ldQhVF!J$L9tNdo5FO_?VZaCF!4gfT30>d z=icXG8l@~Hc`3v9 z&SDWSV#YZFPk&sPoos)Q&7-yMhpQ5vV>)yCaQZ}B;t;E0Yn1b>nQ^!435!L+_c<#T zt2|$@gXqOz5dNsCLWMb4kQAvA@AF z8mOKNz%yO|9{)lFc(R+tzj(^UW-;G4N8EvFR*FBMH0{joy+zyue1l>lPuVRpJ6`}_ zb~pP{J0$k7@5#@I?d-hzjMyXcWIgOg?@{p~>R*qz+W!XY#q_U>HEcb$W*9bk2gS!o zyN^ZAq39qCE1!z{#BV5kCSLJg5ciAxZY^fFDfQT0-j!~~S9y*)caAyib+&Wt4+)D9 zd8d!F4{$#6#Kgp-+dFIt&X&&Ji{PM5 zq;?Im7>b73E1tV-!=&cz?Xx`_Z{|wh>$Z19p6mjSydX6TcPlQbm?avC(hF7uu{JeJ z8isokTvCtd^kHwrtK?Mgs_O4g*D3U zlFokX+a<-&bPt9b_SUl=_K}Gs=dd2J1qgX_zRL?a0Gvgyk!}Is3tU)q#DH@)z zYwQ}n8$LoTg&KzjQ{isJX>bOy8s2qIgj6VvXpgOAu#3BSx5k7xg^%9E#aUl17p=!Wy_jTS@X} zLj3TJJMf#G;~Hqvx=GPT@;;LHp?s(I5Xtuw9wqHDm;i^gWB74MA>ulCMmtX0A(9V~ ze2Cn#0cYVHpW+<6-QoBHW_7;Q8w9BGg=wRXOMgb$s5S4fwYaJ zZ6s|YX*)^MNs>;Ibdh}@$@^G@SJB6K+mBL+V{8q)q#a|MP;!iQA`X#ch$KTK5rsAI zo+b+1MijV>P2da2M)`R}F3%=;wLnFq+@3Il_nS!37urqNj6;+qK|C)$fl2M`pBk_Y>rXlVYiJ zlVil)N6b;eV}vh|=^&X7l4OWbwDGdC39AWfY`nx8qGu4!wDGbUh;Af|5q1*pBkUtQ zYU7(886f5u;S07qP;`nEgCqfo8!?F|&LldE=xU;8O58q%9}N_0`v{Mcc0l4~4U&Z6 zpQnXdrpzNuM0#yP4M~=hq#;7gN|`&v2=|fXD5(dCK1K8((M;jtvIuJkmn%GU1JN;s z$9aGx`$#fCI7rCsp-#UUn% z8Dh66+6HW=ZD(wfG*zmSR!I+HujyRJY>Kj9~y8DFCpDBrRq=Kqv7 z=e7u2h5Lmc3vUWFV!e2i7!!Xf{zYuH9k-=O3nhCmev}8vz2=o=x$J~_bD1aaZRsri zQf43d%?zJ|(ixevHoVwIzTP$ulr76V0w;t4I4hilg<=VODNckPwu!LUb{ShJUd~FS z{(|yyuWR+H^~-7+8&|Dc7w%tnWh(oMVBOr4qHTJ^x>e@P1t*lanW@xn?%!6MpOScd z!nvZe7jowP;=p4+x@*l%Tg{`*0oGs+H&-pbQP8vu&89G8v+Of&WO};;1ZKpV^;o;R zhzZORW{d;L$@JLGY9eDky^f6o6uA^d69hpN^yr}C)1$vbv6u;Vj1>L78NDGhGH6#& z`Hm4CmNEeeL?b3uE2q_M0aPT%h)F5$lAeQ6oZxC*x-j5NfE9>AU$(I=A? z$+*>M!wr5K*(3OmPlFL1aAwk6;5s!7h@w~-&5E%Khr);*!SO+3#fLmTd96GI?!`zb zM`i>!kYZT@q60z2WkiotnqDK?YiVD@%6PBajOfWr!d_~@acTzzr$Dd81HCr7J<)D- zr%v%qy>SD}J#tb4JPw-ZWa;yjBuzsDBYN71er!a~8PU&h`M4+lBDr8hzc6CBV2Nf; zkGXk;F@2Pyv5$U1HRA7VA}YT!DzP#e{l$2|+-QV2I?She<6@^r1&jnN13%i1@1!2P z(P}Gx&KMi!2RdEhQ`%*;VRx4zb;MkBQ-*iIP;Bvj#(eQ+n%i%xj_?-8t1TXRT89w_ zo(d|Ss5p&SMSNpvo~w*l4R1$m79JIA#k9Z+u1p;GFO02B-zt$LmZ3O!-dNd)Kkwo& zx@mYh?A5R%6cMMA?@s@<;Tn1T5j;K7r~|JOT7bY0Qx2Ey;8dCUWLxf1e&1jeoS@$` zO$LT5Jxz}oe(Z|JE;^iu_lzC?7n;{O#|0?rwK_jaN1q%+AHdr$eq7C|8!Bh+#^cN9 z1kVc&c>Flv*~3)Lmg-?tS=2$K_|0Q<@PnmCU&IIX{;3Ub1XdN57L}EkluW58DlTp+ zUNxnBMM+b`ilSAMn^vrtTwdNZxnycnX+=Z-6SrK${NBZNzXmqHR=_s}{!c6v;D6H< zY&6HU`{nIOZr^BDwogd>U{}WZ-184t_tq@ESfPB{WUg&rFgY%KJS8sVq3Zv!=jGeg z!%M#X!#CMm=s)sxj?B*>_iqBH?Y%n8{ZoyX3uSd_Yo+9P{0hJ{o A%K!iX