ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make preferred core labels more verbose 

they now display all system choices that they set instead of just the first
This commit is contained in:
Morilli 2024-07-08 03:03:34 +02:00
parent d74b130c22
commit 81e2b5b47b
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/BizHawk.Client.EmuHawk/MainForm.cs
View File

@ -88,8 +88,7 @@ namespace BizHawk.Client.EmuHawk
foreach (var (appliesTo, coreNames) in Config.CorePickerUIData) foreach (var (appliesTo, coreNames) in Config.CorePickerUIData)
{ {
var groupLabel = appliesTo[0]; var submenu = new ToolStripMenuItem { Text = string.Join(" | ", appliesTo) };
var submenu = new ToolStripMenuItem { Text = groupLabel };
submenu.DropDownItems.AddRange(coreNames.Select(coreName => { submenu.DropDownItems.AddRange(coreNames.Select(coreName => {
var entry = new ToolStripMenuItem { Text = coreName }; var entry = new ToolStripMenuItem { Text = coreName };
entry.Click += (_, _) => entry.Click += (_, _) =>
@ -103,14 +102,13 @@ namespace BizHawk.Client.EmuHawk
}).ToArray()); }).ToArray());
submenu.DropDownOpened += (openedSender, _1) => submenu.DropDownOpened += (openedSender, _1) =>
{ {
_ = Config.PreferredCores.TryGetValue(groupLabel, out var preferred); _ = Config.PreferredCores.TryGetValue(appliesTo[0], out var preferred);
if (!coreNames.Contains(preferred)) if (!coreNames.Contains(preferred))
{ {
// invalid --> default (doing this here rather than when reading config file to allow for hacked-in values, though I'm not sure if that could do anything at the moment --yoshi) // invalid --> default (doing this here rather than when reading config file to allow for hacked-in values, though I'm not sure if that could do anything at the moment --yoshi)
var defaultCore = coreNames[0]; var defaultCore = coreNames[0];
Console.WriteLine($"setting preferred core for {groupLabel} etc. to {defaultCore} (was {preferred ?? "null"})"); Console.WriteLine($"setting preferred core for {appliesTo[0]} etc. to {defaultCore} (was {preferred ?? "null"})");
preferred = defaultCore; Config.PreferredCores[appliesTo[0]] = preferred = defaultCore;
foreach (var sysID in appliesTo) Config.PreferredCores[sysID] = preferred;
} }
foreach (ToolStripMenuItem entry in ((ToolStripMenuItem) openedSender).DropDownItems) entry.Checked = entry.Text == preferred; foreach (ToolStripMenuItem entry in ((ToolStripMenuItem) openedSender).DropDownItems) entry.Checked = entry.Text == preferred;
}; };