diff --git a/src/BizHawk.Client.EmuHawk/GlobalWin.cs b/src/BizHawk.Client.EmuHawk/GlobalWin.cs index 1674cdbbca..ef4f4976a9 100644 --- a/src/BizHawk.Client.EmuHawk/GlobalWin.cs +++ b/src/BizHawk.Client.EmuHawk/GlobalWin.cs @@ -37,7 +37,6 @@ namespace BizHawk.Client.EmuHawk public static Dictionary UserBag { get; set; } = new Dictionary(); public static Config Config { get; set; } - public static FirmwareManager FirmwareManager { get; set; } public static GameInfo Game { get; set; } public static IMovieSession MovieSession { get; set; } public static InputManager InputManager { get; } = new InputManager(); diff --git a/src/BizHawk.Client.EmuHawk/IEmuHawkMainFormToConfig.cs b/src/BizHawk.Client.EmuHawk/IEmuHawkMainFormToConfig.cs index 38c8035b9b..41bd4edc1b 100644 --- a/src/BizHawk.Client.EmuHawk/IEmuHawkMainFormToConfig.cs +++ b/src/BizHawk.Client.EmuHawk/IEmuHawkMainFormToConfig.cs @@ -10,6 +10,9 @@ namespace BizHawk.Client.EmuHawk /// only referenced from IEmulator Emulator { get; } + /// only referenced from + FirmwareManager FirmwareManager { get; } + IMovieSession MovieSession { get; } void AddOnScreenMessage(string message); diff --git a/src/BizHawk.Client.EmuHawk/IEmuHawkMainFormToTools.cs b/src/BizHawk.Client.EmuHawk/IEmuHawkMainFormToTools.cs index 124fb3273e..ca311cd584 100644 --- a/src/BizHawk.Client.EmuHawk/IEmuHawkMainFormToTools.cs +++ b/src/BizHawk.Client.EmuHawk/IEmuHawkMainFormToTools.cs @@ -18,6 +18,9 @@ namespace BizHawk.Client.EmuHawk /// only referenced from bool EmulatorPaused { get; } + /// only referenced from + FirmwareManager FirmwareManager { get; } + /// only referenced from bool GameIsClosing { get; } diff --git a/src/BizHawk.Client.EmuHawk/MainForm.cs b/src/BizHawk.Client.EmuHawk/MainForm.cs index 9d55917efb..42bb8bb828 100644 --- a/src/BizHawk.Client.EmuHawk/MainForm.cs +++ b/src/BizHawk.Client.EmuHawk/MainForm.cs @@ -162,7 +162,7 @@ namespace BizHawk.Client.EmuHawk { var cfp = new CoreFileProvider( ShowMessageCoreComm, - GlobalWin.FirmwareManager, + FirmwareManager, Config.PathEntries, Config.FirmwareUserSpecifications); var prefs = CoreComm.CorePreferencesFlags.None; @@ -282,7 +282,7 @@ namespace BizHawk.Client.EmuHawk base.Config = Config; InputManager.ControllerInputCoalescer = new ControllerInputCoalescer(); - GlobalWin.FirmwareManager = new FirmwareManager(); + FirmwareManager = new FirmwareManager(); MovieSession = new MovieSession( Config.Movies, Config.PathEntries.MovieBackupsAbsolutePath(), @@ -874,7 +874,7 @@ namespace BizHawk.Client.EmuHawk AddOnScreenMessage(Rewinder?.Active == true ? "Rewind started" : "Rewind disabled"); } - private FirmwareManager FirmwareManager => GlobalWin.FirmwareManager; + public FirmwareManager FirmwareManager { get; } protected override void OnActivated(EventArgs e) { @@ -3558,7 +3558,7 @@ namespace BizHawk.Client.EmuHawk MessageCallback = OSD.AddMessage, OpenAdvanced = args.OpenAdvanced }; - GlobalWin.FirmwareManager.RecentlyServed.Clear(); + FirmwareManager.RecentlyServed.Clear(); loader.OnLoadError += ShowLoadError; loader.OnLoadSettings += CoreSettings; diff --git a/src/BizHawk.Client.EmuHawk/config/FirmwaresConfig.cs b/src/BizHawk.Client.EmuHawk/config/FirmwaresConfig.cs index d7398edd9f..6dd0f64692 100644 --- a/src/BizHawk.Client.EmuHawk/config/FirmwaresConfig.cs +++ b/src/BizHawk.Client.EmuHawk/config/FirmwaresConfig.cs @@ -252,7 +252,7 @@ namespace BizHawk.Client.EmuHawk DoScan(); } - private FirmwareManager Manager => GlobalWin.FirmwareManager; + private FirmwareManager Manager => _mainForm.FirmwareManager; private void DoScan() { diff --git a/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.cs b/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.cs index 363014de55..0b20544d90 100644 --- a/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.cs +++ b/src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.cs @@ -618,7 +618,7 @@ namespace BizHawk.Client.EmuHawk tasMovie.PopulateWithDefaultHeaderValues( Emulator, Game, - GlobalWin.FirmwareManager, + MainForm.FirmwareManager, Config.DefaultAuthor); SetTasMovieCallbacks(tasMovie);