From 7ed8704555349b4124fd554ab74c60c35b7686f1 Mon Sep 17 00:00:00 2001
From: adelikat <adelikat@tasvideos.org>
Date: Sun, 25 Jan 2015 14:37:37 +0000
Subject: [PATCH] add a CanPoke() extension method for memory domains, checks
 for a null or not implemented Poke Poke delegate, use it to disable Poke on
 Ram Search and Ram Watch, still todo - hex editor and lua

---
 .../tools/Watch/RamSearch.cs                  | 11 +++++++---
 .../tools/Watch/RamWatch.cs                   |  9 +++++++-
 .../Base Implementations/MemoryDomain.cs      |  6 ++++++
 BizHawk.Emulation.Common/Extensions.cs        | 21 +++++++++++++++++++
 .../Consoles/Nintendo/NES/FDS/FDS.cs          |  2 +-
 5 files changed, 44 insertions(+), 5 deletions(-)

diff --git a/BizHawk.Client.EmuHawk/tools/Watch/RamSearch.cs b/BizHawk.Client.EmuHawk/tools/Watch/RamSearch.cs
index 5d06689731..600fa17a3e 100644
--- a/BizHawk.Client.EmuHawk/tools/Watch/RamSearch.cs
+++ b/BizHawk.Client.EmuHawk/tools/Watch/RamSearch.cs
@@ -1173,10 +1173,13 @@ namespace BizHawk.Client.EmuHawk
 
 			RemoveMenuItem.Enabled =
 				AddToRamWatchMenuItem.Enabled =
-				PokeAddressMenuItem.Enabled =
 				FreezeAddressMenuItem.Enabled =
 				SelectedIndices.Any();
 
+			PokeAddressMenuItem.Enabled =
+				SelectedIndices.Any() &&
+				SelectedWatches.All(w => w.Domain.CanPoke());
+
 			UndoMenuItem.Enabled =
 				ClearUndoMenuItem.Enabled =
 				_searches.CanUndo;
@@ -1379,13 +1382,15 @@ namespace BizHawk.Client.EmuHawk
 
 			RemoveContextMenuItem.Visible =
 				AddToRamWatchContextMenuItem.Visible =
-				PokeContextMenuItem.Visible =
 				FreezeContextMenuItem.Visible =
 				ContextMenuSeparator2.Visible =
-
 				ViewInHexEditorContextMenuItem.Visible =
 				SelectedIndices.Any();
 
+			PokeContextMenuItem.Enabled =
+				SelectedIndices.Any() &&
+				SelectedWatches.All(w => w.Domain.CanPoke());
+
 			UnfreezeAllContextMenuItem.Visible = Global.CheatList.ActiveCount > 0;
 
 			ContextMenuSeparator3.Visible = SelectedIndices.Any() || (Global.CheatList.ActiveCount > 0);
diff --git a/BizHawk.Client.EmuHawk/tools/Watch/RamWatch.cs b/BizHawk.Client.EmuHawk/tools/Watch/RamWatch.cs
index 2361a187ce..144bd8cc61 100644
--- a/BizHawk.Client.EmuHawk/tools/Watch/RamWatch.cs
+++ b/BizHawk.Client.EmuHawk/tools/Watch/RamWatch.cs
@@ -687,10 +687,13 @@ namespace BizHawk.Client.EmuHawk
 				RemoveWatchMenuItem.Enabled =
 				MoveUpMenuItem.Enabled =
 				MoveDownMenuItem.Enabled =
-				PokeAddressMenuItem.Enabled =
 				FreezeAddressMenuItem.Enabled =
 				SelectedIndices.Any();
 
+			PokeAddressMenuItem.Enabled =
+				SelectedIndices.Any() &&
+				SelectedWatches.All(w => w.Domain.CanPoke());
+
 			PauseMenuItem.Text = _paused ? "Unpause" : "Pause";
 		}
 
@@ -1008,6 +1011,10 @@ namespace BizHawk.Client.EmuHawk
 				Separator6.Visible = 
 				indexes.Count > 0;
 
+			PokeContextMenuItem.Enabled =
+				SelectedIndices.Any() &&
+				SelectedWatches.All(w => w.Domain.CanPoke());
+
 			var allCheats = _watches.All(x => Global.CheatList.IsActive(x.Domain, x.Address ?? 0));
 
 			if (allCheats)
diff --git a/BizHawk.Emulation.Common/Base Implementations/MemoryDomain.cs b/BizHawk.Emulation.Common/Base Implementations/MemoryDomain.cs
index 26de0c301b..67f9ca0a93 100644
--- a/BizHawk.Emulation.Common/Base Implementations/MemoryDomain.cs	
+++ b/BizHawk.Emulation.Common/Base Implementations/MemoryDomain.cs	
@@ -52,7 +52,13 @@ namespace BizHawk.Emulation.Common
 				delegate(long addr, byte val)
 				{
 					if (writable)
+					{
 						data[addr] = val;
+					}
+					else
+					{
+						throw new NotImplementedException();
+					}
 				}
 			);
 		}
diff --git a/BizHawk.Emulation.Common/Extensions.cs b/BizHawk.Emulation.Common/Extensions.cs
index ca15613df0..6db004c83e 100644
--- a/BizHawk.Emulation.Common/Extensions.cs
+++ b/BizHawk.Emulation.Common/Extensions.cs
@@ -163,6 +163,27 @@ namespace BizHawk.Emulation.Common.IEmulatorExtensions
 			return (IDisassemblable)core.ServiceProvider.GetService<IDisassemblable>();
 		}
 
+		public static bool CanPoke(this MemoryDomain d)
+		{
+			if (d.PokeByte == null)
+			{
+				return false;
+			}
+			
+			try
+			{
+				d.PokeByte(0, d.PeekByte(0));
+			}
+			catch (NotImplementedException)
+			{
+				return false;
+			}
+
+			return true;
+
+
+		}
+
 		// TODO: a better place for these
 		public static bool IsImplemented(this MethodInfo info)
 		{
diff --git a/BizHawk.Emulation.Cores/Consoles/Nintendo/NES/FDS/FDS.cs b/BizHawk.Emulation.Cores/Consoles/Nintendo/NES/FDS/FDS.cs
index 090c5736f0..8fea83ef46 100644
--- a/BizHawk.Emulation.Cores/Consoles/Nintendo/NES/FDS/FDS.cs
+++ b/BizHawk.Emulation.Cores/Consoles/Nintendo/NES/FDS/FDS.cs
@@ -228,7 +228,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.NES
 
 		public MemoryDomain GetDiskPeeker()
 		{
-			return new MemoryDomain("FDS SIDE", diskdrive.NumBytes, MemoryDomain.Endian.Little, diskdrive.PeekData, null); // silent poke fail TODO: don't pass null! Throw a not implemented exception, handle this exception in ram tools
+			return new MemoryDomain("FDS SIDE", diskdrive.NumBytes, MemoryDomain.Endian.Little, diskdrive.PeekData, null);
 		}
 
 		void SetIRQ()