ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update libstdc++ dll and friends, also fix a crash in gambatte due to OOB string accesses

This commit is contained in:
CasualPokePlayer 2024-05-29 18:58:08 -07:00
parent db75fda3b8
commit 7e6e9705ae
7 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

BIN
Assets/dll/libgambatte.dll
View File

Binary file not shown.

BIN
Assets/dll/libgcc_s_seh-1.dll
View File

Binary file not shown.

BIN
Assets/dll/libstdc++-6.dll
View File

Binary file not shown.

BIN
Assets/dll/libwinpthread-1.dll
View File

Binary file not shown.

8
src/BizHawk.Emulation.Cores/Consoles/Nintendo/Gameboy/Gambatte.cs
View File

@ -195,15 +195,15 @@ namespace BizHawk.Emulation.Cores.Nintendo.Gameboy
InitMemoryDomains();
var mbcBuf = new byte[32];
var mbcBuf = new byte[32 + 1];
LibGambatte.gambatte_pakinfo(GambatteState, mbcBuf, out var rambanks, out var rombanks, out var crc, out var headerchecksumok);
var romNameBuf = new byte[32];
var romNameBuf = new byte[16 + 1];
LibGambatte.gambatte_romtitle(GambatteState, romNameBuf);
var romname = Encoding.ASCII.GetString(romNameBuf).TrimEnd();
var romname = Encoding.ASCII.GetString(romNameBuf).TrimEnd('\0');
RomDetails = $"{game.Name}\r\n{SHA1Checksum.ComputePrefixedHex(file)}\r\n{MD5Checksum.ComputePrefixedHex(file)}\r\n\r\n";
BoardName = Encoding.ASCII.GetString(mbcBuf).TrimEnd();
BoardName = Encoding.ASCII.GetString(mbcBuf).TrimEnd('\0');
RomDetails += $"Core reported Header Name: {romname}\r\n";
RomDetails += $"Core reported RAM Banks: {rambanks}\r\n";

2
src/BizHawk.Emulation.Cores/Consoles/Nintendo/Gameboy/LibGambatte.cs
View File

@ -411,7 +411,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.Gameboy
/// Pakinfo of currently loaded ROM image.
/// </summary>
/// <param name="core">opaque state pointer</param>
/// <param name="mbc">enough room for 25 ascii chars plus terminator</param>
/// <param name="mbc">enough room for 32 ascii chars plus terminator</param>
/// <param name="rambanks">number of rambanks</param>
/// <param name="rombanks">number of rombanks</param>
/// <param name="crc">core reported crc32</param>

2
submodules/gambatte

@ -1 +1 @@
Subproject commit e35e24de89f06642852f622d7d4159ba6a4abea2
Subproject commit 0838651ca7c06d8c236834dcf5aa307092b2a82e