From 75a991a36d3f35a39891c5c55d5c61e2f91be840 Mon Sep 17 00:00:00 2001
From: adelikat <adelikat@tasvideos.org>
Date: Sun, 23 Feb 2020 13:23:38 -0600
Subject: [PATCH] bad attempt at wiring up mGBA memory hooks

---
 .../Consoles/Nintendo/GBA/LibmGBA.cs          |  12 +++
 .../Nintendo/GBA/MGBAHawk.IDebuggable.cs      |   2 +-
 .../Nintendo/GBA/MGBAMemoryCallbackSystem.cs  | 100 ++++++++++++++++++
 3 files changed, 113 insertions(+), 1 deletion(-)
 create mode 100644 BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/MGBAMemoryCallbackSystem.cs

diff --git a/BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/LibmGBA.cs b/BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/LibmGBA.cs
index 6f9f3084c5..5c60ca1238 100644
--- a/BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/LibmGBA.cs
+++ b/BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/LibmGBA.cs
@@ -143,5 +143,17 @@ namespace BizHawk.Emulation.Cores.Nintendo.GBA
 		[DllImport(dll, CallingConvention = cc)]
 		public static extern void BizSetTraceCallback(TraceCallback cb);
 
+		public enum mWatchpointType {
+			WATCHPOINT_WRITE = 1,
+			WATCHPOINT_READ = 2,
+			WATCHPOINT_RW = 3,
+			WATCHPOINT_WRITE_CHANGE = 4,
+		};
+
+		[UnmanagedFunctionPointer(cc)]
+		public delegate void MemCallback(uint addr, mWatchpointType type, uint oldValue, uint newValue);
+
+		[DllImport(dll, CallingConvention = cc)]
+		public static extern void BizSetMemCallback(MemCallback cb);
 	}
 }
diff --git a/BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/MGBAHawk.IDebuggable.cs b/BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/MGBAHawk.IDebuggable.cs
index 1fd8c676d9..5c14ec81f2 100644
--- a/BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/MGBAHawk.IDebuggable.cs
+++ b/BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/MGBAHawk.IDebuggable.cs
@@ -27,7 +27,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.GBA
 		}
 
 		[FeatureNotImplemented]
-		public IMemoryCallbackSystem MemoryCallbacks => throw new NotImplementedException();
+		public IMemoryCallbackSystem MemoryCallbacks { get; } = new MGBAMemoryCallbackSystem();
 
 		public bool CanStep(StepType type) => false;
 
diff --git a/BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/MGBAMemoryCallbackSystem.cs b/BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/MGBAMemoryCallbackSystem.cs
new file mode 100644
index 0000000000..883350a9f0
--- /dev/null
+++ b/BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/MGBAMemoryCallbackSystem.cs
@@ -0,0 +1,100 @@
+using System;
+using System.Collections;
+using System.Collections.Generic;
+using System.Linq;
+using BizHawk.Emulation.Common;
+
+namespace BizHawk.Emulation.Cores.Nintendo.GBA
+{
+	public class MGBAMemoryCallbackSystem : IMemoryCallbackSystem
+	{
+		private readonly List<CallbackContainer> _callbacks = new List<CallbackContainer>();
+
+		public string[] AvailableScopes { get; } = { "System Bus" };
+		public bool ExecuteCallbacksAvailable => false;
+
+		public bool HasReads => _callbacks.Any(c => c.Callback.Type == MemoryCallbackType.Read);
+		public bool HasWrites => _callbacks.Any(c => c.Callback.Type == MemoryCallbackType.Write);
+		public bool HasExecutes => _callbacks.Any(c => c.Callback.Type == MemoryCallbackType.Execute);
+
+		public bool HasReadsForScope(string scope) =>
+			_callbacks.Any(c => c.Callback.Scope == scope
+				&& c.Callback.Type == MemoryCallbackType.Read);
+
+		public bool HasWritesForScope(string scope) =>
+			_callbacks.Any(c => c.Callback.Scope == scope
+				&& c.Callback.Type == MemoryCallbackType.Write);
+
+		public bool HasExecutesForScope(string scope) =>
+			_callbacks.Any(c => c.Callback.Scope == scope
+				&& c.Callback.Type == MemoryCallbackType.Execute);
+
+		public void Add(IMemoryCallback callback)
+		{
+			if (!AvailableScopes.Contains(callback.Scope))
+			{
+				throw new InvalidOperationException($"{callback.Scope} is not currently supported for callbacks");
+			}
+
+			var container = new CallbackContainer(callback);
+
+			LibmGBA.BizSetMemCallback(container.Call);
+			_callbacks.Add(container);
+		}
+
+		public void Remove(MemoryCallbackDelegate action)
+		{
+			// TODO
+		}
+
+		public void RemoveAll(IEnumerable<MemoryCallbackDelegate> actions)
+		{
+			// TODO
+		}
+
+		public void Clear()
+		{
+			// TODO
+		}
+
+		public IEnumerator<IMemoryCallback> GetEnumerator() => _callbacks.Select(c => c.Callback).GetEnumerator();
+		IEnumerator IEnumerable.GetEnumerator() => _callbacks.Select(c => c.Callback).GetEnumerator();
+
+		public void CallMemoryCallbacks(uint addr, uint value, uint flags, string scope)
+		{
+			// Not a thing in this implementation
+		}
+	}
+
+	internal class CallbackContainer
+	{
+		public CallbackContainer(IMemoryCallback callBack)
+		{
+			Callback = callBack;
+		}
+
+		public IMemoryCallback Callback { get; }
+
+		public LibmGBA.mWatchpointType WatchPointType
+		{
+			get
+			{
+				switch (Callback.Type)
+				{
+					default:
+					case MemoryCallbackType.Read:
+						return LibmGBA.mWatchpointType.WATCHPOINT_READ;
+					case MemoryCallbackType.Write:
+						return LibmGBA.mWatchpointType.WATCHPOINT_WRITE;
+					case MemoryCallbackType.Execute:
+						throw new NotImplementedException("Executes not implemented yet");
+				}
+			}
+		}
+
+		public void Call(uint addr, LibmGBA.mWatchpointType type, uint oldValue, uint newValue)
+		{
+			Callback.Callback?.Invoke(addr, newValue, 0);
+		}
+	}
+}