ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Enable CA1868 and fix noncompliance 

"Unnecessary call to 'Contains' for sets"
This commit is contained in:
YoshiRulz 2025-03-29 08:05:38 +10:00
parent 5de736af0e
commit 6b06d50085
No known key found for this signature in database
GPG Key ID: C4DE31C245353FB7
3 changed files with 6 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.global.editorconfig.ini
View File

@ -99,6 +99,8 @@ dotnet_diagnostic.CA1854.severity = warning
dotnet_diagnostic.CA1860.severity = error
# Use the 'StringComparison' method overloads to perform case-insensitive string comparisons
dotnet_diagnostic.CA1862.severity = error
# Unnecessary call to 'Contains' for sets
dotnet_diagnostic.CA1868.severity = warning
## Reliability rules

4
src/BizHawk.Client.EmuHawk/MainForm.cs
View File

@ -2140,10 +2140,8 @@ namespace BizHawk.Client.EmuHawk
var sysID = Emulator.SystemId;
for (var i = 0; i < sysID.Length; i++)
{
var upper = char.ToUpperInvariant(sysID[i]);
if (AvailableAccelerators.Contains(upper))
if (AvailableAccelerators.Remove(char.ToUpperInvariant(sysID[i])))
{
AvailableAccelerators.Remove(upper);
sysID = sysID.Insert(i, "&");
break;
}

16
src/BizHawk.Common/Log.cs
View File

@ -19,23 +19,13 @@ namespace BizHawk.Common
}
// -------------- Logging Domain Configuration --------------
private static readonly List<string> EnabledLogDomains = new List<string>();
private static readonly HashSet<string> EnabledLogDomains = new();
public static void EnableDomain(string domain)
{
if (!EnabledLogDomains.Contains(domain))
{
EnabledLogDomains.Add(domain);
}
}
=> EnabledLogDomains.Add(domain);
public static void DisableDomain(string domain)
{
if (EnabledLogDomains.Contains(domain))
{
EnabledLogDomains.Remove(domain);
}
}
=> EnabledLogDomains.Remove(domain);
// -------------- Logging Action Configuration --------------
#pragma warning disable CA2211 // public field