From 694ba93ec164a318ec8e46b85d255ccd9a2ff88b Mon Sep 17 00:00:00 2001 From: adelikat Date: Sat, 15 Jun 2019 13:10:31 -0500 Subject: [PATCH] I think this is the correct wasLag logic --- .../movie/tasproj/TasLagLog.cs | 22 ++++++++++++------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/BizHawk.Client.Common/movie/tasproj/TasLagLog.cs b/BizHawk.Client.Common/movie/tasproj/TasLagLog.cs index de3b5d408f..13b9e2d43f 100644 --- a/BizHawk.Client.Common/movie/tasproj/TasLagLog.cs +++ b/BizHawk.Client.Common/movie/tasproj/TasLagLog.cs @@ -35,7 +35,7 @@ namespace BizHawk.Client.Common { if (!value.HasValue) { - _lagLog.Remove(frame); + RemoveLagEntry(frame); return; } @@ -54,13 +54,7 @@ namespace BizHawk.Client.Common var frames = _lagLog.Keys.Where(k => k > frame).ToList(); foreach (var f in frames) { - bool lag; - if (_lagLog.TryGetValue(f, out lag)) - { - _wasLag[f] = lag; - } - - _lagLog.Remove(f); + RemoveLagEntry(frame); } return frames.Any(); @@ -116,5 +110,17 @@ namespace BizHawk.Client.Common _wasLag.Remove(i); } } + + private void RemoveLagEntry(int frame) + { + bool lag; + var result = _lagLog.TryGetValue(frame, out lag); + if (result) + { + _wasLag[frame] = lag; + } + + _lagLog.Remove(frame); + } } }