From 65f5aecfa64762118dbc1002540545079226db00 Mon Sep 17 00:00:00 2001 From: YoshiRulz Date: Wed, 28 Sep 2022 06:43:31 +1000 Subject: [PATCH] Fix warnings in external .NET projects --- .../BizHawk.Analyzer/BizHawk.Analyzer.csproj | 3 +++ .../ReflectionCacheGenerator.cs | 4 ++-- ExternalProjects/iso-parser/ISOParser.csproj | 3 +++ References/BizHawk.SrcGen.ReflectionCache.dll | Bin 12288 -> 12288 bytes 4 files changed, 8 insertions(+), 2 deletions(-) diff --git a/ExternalProjects/BizHawk.Analyzer/BizHawk.Analyzer.csproj b/ExternalProjects/BizHawk.Analyzer/BizHawk.Analyzer.csproj index 3730f61f99..f00e728611 100644 --- a/ExternalProjects/BizHawk.Analyzer/BizHawk.Analyzer.csproj +++ b/ExternalProjects/BizHawk.Analyzer/BizHawk.Analyzer.csproj @@ -3,6 +3,9 @@ netstandard2.0 + + $(NoWarn);SA1200 + diff --git a/ExternalProjects/BizHawk.SrcGen.ReflectionCache/ReflectionCacheGenerator.cs b/ExternalProjects/BizHawk.SrcGen.ReflectionCache/ReflectionCacheGenerator.cs index 6eac7ebaf7..da91f2b4a9 100644 --- a/ExternalProjects/BizHawk.SrcGen.ReflectionCache/ReflectionCacheGenerator.cs +++ b/ExternalProjects/BizHawk.SrcGen.ReflectionCache/ReflectionCacheGenerator.cs @@ -31,7 +31,7 @@ namespace BizHawk.SrcGen.ReflectionCache private string CalcNamespace() { // black magic wizardry to find common prefix https://stackoverflow.com/a/35081977 - var ns = new string(_namespaces.First() + var ns = new string(_namespaces[0] .Substring(0, _namespaces.Min(s => s.Length)) .TakeWhile((c, i) => _namespaces.All(s => s[i] == c)) .ToArray()); @@ -44,7 +44,7 @@ namespace BizHawk.SrcGen.ReflectionCache { SimpleNameSyntax simple => simple.Identifier.ValueText, QualifiedNameSyntax qual => $"{Ser(qual.Left)}.{Ser(qual.Right)}", - _ => throw new Exception() + _ => throw new InvalidOperationException() }; if (_namespace != null || syntaxNode is not NamespaceDeclarationSyntax syn) return; var newNS = Ser(syn.Name); diff --git a/ExternalProjects/iso-parser/ISOParser.csproj b/ExternalProjects/iso-parser/ISOParser.csproj index 0cc0389291..1998f3b543 100644 --- a/ExternalProjects/iso-parser/ISOParser.csproj +++ b/ExternalProjects/iso-parser/ISOParser.csproj @@ -3,4 +3,7 @@ netstandard2.0 + + disable + diff --git a/References/BizHawk.SrcGen.ReflectionCache.dll b/References/BizHawk.SrcGen.ReflectionCache.dll index 961d13f4c7e89fd63a3288b0f1fcb842dca292e1..c53a868b7bc14a298a5c41118b19a1548d2af81f 100644 GIT binary patch delta 3117 zcmZ8j4Qy3s8GhdLdwW|hx3@o(($U-Amhv+i24M>sWw27E{Ma986bu=qR?-c)9TWs1 z-qvnoAP_FcOgD{&G@@k5M$(bYIT=eKlPSs8OazBRR_&6BL!u_gbozYnyf~?1fTZN@ zK&&FSpbC&cW;_(MT8n~b?B4{3ty@96Q(wFnfCUs^&9TwW0M`WUDCZf3 zz1aoUjw!);_l<@>3-VJr?MQ~dW>$dHYcJOuaQG8ADI5CV5Tod^cOrhhN^$n|q$~vB|haYO=8;aeoY5%DEU)HY+QF>u}hgny7IW?M;revX~xl^MqQqc_NVG@oM!LUzG>N18Z| zEJD_0x6rc@QnoY8I6?H{PR8TZNHm4N^4v`*=bmPzhB}y_>|mBfl&w_enu%oOkTMUP zWwLfH_OVDolusCa@dS~n%COIdt3p#DvHzxyxJzVt5%v}6H%+73)L&cbWFn% ze~C;(gWDukXpm*ZxZ-+Q@wu_c0%Y8_{!z4u;76)>e!Dz~b66{-yoc*`+?gV|58dM7 zpxZ+H6kDV<&c1l2Y@Bl>_)3oLWU1a9+e4PhG2?3ENSZL?7d#9$2 zbvefQx3Mut4SW0^wk^X#QTLG8_-4*alkLwjkEWj5}NWNa&IR9gQ}I45TODT`WMq-I>MB}TQx zsPCegC*HyBcia<>%(9(K3}Xf{iU$-IC@xWKR%|nv!dfMrL=U@(B^c20zZ6A`o~PKO z%1z=FJdbDmDjdT$uO5@-lh8ck?a%_^d;UUH$?JF&Gvuyq1N$|%0H@qdDAo!K z$BRWg+;`9*hqXBNn#`R5?83cn%Ic1VjnR~Y~rlATP-QTS zMjxd9hII@nQ(_2D5Z_dLgvPivg6&jBu!ndSgT!m-(9n%1R3U79v1)i`Jk((RQ&x{K^V zbqCcQQg=w*A$5n;9a8s|UK!KmF-;z0P`5p%L1P*O%UqvWrm@Z2 z8MAFmuhKGCnXt@hCDd)y$PJ2Jiv5a%im*+c#fosuIBqay^*g4-ABnvZcMaBIJuc!p z^0})C*N4R=X7d&0U?M+6qVV~U@!>|Xd!CQxEyv)nf8lfELTfaqd{;*K4#;N}3lZ+P zmR7O2>ZaMJKi(jhn$E(L~Ek*~wz&GtD&4{O0i^#f9f=FxzCXylhh6OXmnH+(AksvFwW-S=2?U-y<^b7^C=dF#&3%{^ah>FwUu z+1HcYI{b3!4ar}I+G8|pE?o3-cdUVNCzxVz;Z~xa1 z1eX$3F*hy}+wJ*wY-uFo#1ZQV3To|B85+~XW^4}99p3#@N4H4 zv$O5RmhsrlW2JA(1g*7`3QXz3Rf=uFrrO#_Y`q(|EIZ^vBC+n_^Mzd`Q*4|4P} A=Kufz delta 3121 zcmZ8j4RBOf89m>9f16EMb~hxDhQfv=KY$6eNIIaAu_3h-u!O&sGIW4QJCVOafVLuR zVoJw42*lTRYNjHXii3_FFw!YX?Ua;h84W|r)GDA83{bTqFvC<@)bZSJ*PYV0^UmIL z&i8%yzIWff@3k*$U$*<(ZaDqu#jYJA<)2*#9+2)(q}toq1S|+E%;&sF7XHeuap zAZq^WrvSf=5Up{j*0|yOZtVyZPcm4@Y--FdWOi-T*;F2ud%H(@j2mA($-z7ZkR;5e z+c}D;Ut450jS5eAuQ&X)07!4+prgRm2;1{FZfITmXd4qSqZmk0PcNL0uQ4%BE&Y{+ zGiUIBBl(Nraeq~Yb$NWxXPu4Y})?pJ!Yr!0bD z%I?gu5@iRJ6<|1ok-zj$Ni*x0!694CFBGZs{o7>;T5)tfC<+A^<)Z;i-N-6JQtG3r>NN&dl z@v*~OLcEDBGB?G3@$`s(&XM53JbQ|z9?P?5$TE3my`6bx^Pazj?YV{R&$39|%j{y} z%XyQ#0A9;8pR;>B7kb^@B?kR@kGlfS<-F&E7sSDZycg%}{yWcpATA2IeejYZwu*=1 z9AjRFv^-0By**^p^6Y>Fn44!l3h-bqafqps0xZjWaeC`=p6w!v$MarD_O!A~a;JAt z3UM&UK5$==OcCxIqhr(CJp>D~Eb=X>k|Fq}vJUK4=B91rCFzx;^j0d%PE!m|DC@vF z9FrIhDhv5!z0F51HrD2KjX3R}lmu>5md#6KFh*%7pU8Fx z4sAc9*roV=#a6`v>G#WV2y2209Km9LBFf}!|>@m;dgS z-bHR6|G`z_x!@h59s1Z@g`J)wf5SAtLO#amNR?c}iC_TN@NO_(?BFI!Gb{Vt{c3Qp z)MZeJ3sQ$-Tqc&I$kZW?65<5RCQim<#4lhgu@T=P&Qg6ou@Ot~95G64;;e6z<*Kyg z(CRH{!G6=BN@otO-buaRJcY~_l6`9QP`Yk3#+K6wc-luw>>V2x8SACFr)EQKL zP<4nMkSIFRf|TQkt>%cW=8EmBLftgodM7QbGL+J4H)=woCN!$DOhcDT5_?UHj6pZi zUS$g-XFDw#*`kr1>UOHzscxsbo$Bt@Iz8HDkLo?D_c1HeZTd8=k9M2Wr*@y(=T#r1 zo^l3NA5#Hgf;{FD*S){)@L(oDMIfD~kP;NV0vqA2`Vwv6!1ea(Os>Y+Y?p zTx1kVlI{EW=R_qIu-#!|k>a?RNKRL26e8ievG+Hx(d_kZN=(cvNv@Qb$J)hk14+)! zWgDAqZp}6Yft%cvd@`2U%I*_eofNdvrZA|ST*@+zpS;)gIY>5UM||69_|?kc;rhzT z+Y*ayCyAvNldWFL7$@REV#)QrFIAqB$-o+?XFFuhT<*pA8PB(ycvjn6nmz0+@VgdP zYP*ML_~YuaLywO8#>M%AP2C?JE?n@&^zGpvs(*M#PCJv+SlHV$^P@+itq;BR%Dl-R m9%J(Vk8`%2>Z&M}lfAFk%#z;N_)i>jwZ1n|cSX7;1^)xzTQlGQ