ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix typos from `&&`/`||` refactoring 

fixes 5685befe1
This commit is contained in:
James Groom 2024-03-27 02:21:50 +00:00 committed by GitHub
parent 5685befe14
commit 651c79abeb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/BizHawk.Emulation.Cores/Computers/AmstradCPC/Hardware/Datacorder/DatacorderDevice.cs
View File

@ -222,8 +222,8 @@ namespace BizHawk.Emulation.Cores.Computers.AmstradCPC
// sign that the tape is no longer playing // sign that the tape is no longer playing
_tapeIsPlaying = false; _tapeIsPlaying = false;
if (_currentDataBlockIndex >= 0 && // we are at datablock 1 or above //TODO 1-indexed then? --yoshi if (_currentDataBlockIndex >= 0 // we are at datablock 1 or above //TODO 1-indexed then? --yoshi
_position >= _dataBlocks[_currentDataBlockIndex].DataPeriods.Count - 1) // the block is still playing back && _position >= _dataBlocks[_currentDataBlockIndex].DataPeriods.Count - 1) // the block is still playing back
{ {
// move to the next block // move to the next block
_currentDataBlockIndex++; _currentDataBlockIndex++;

4
src/BizHawk.Emulation.Cores/Computers/SinclairSpectrum/Hardware/Datacorder/DatacorderDevice.cs
View File

@ -200,7 +200,7 @@ namespace BizHawk.Emulation.Cores.Computers.SinclairSpectrum
_waitEdge = 0; _waitEdge = 0;
_position = 0; _position = 0;
if (_currentDataBlockIndex < 0 && _dataBlocks.Count > 0) if (_currentDataBlockIndex < 0 && _dataBlocks.Count > 0) //TODO deleted a comment that said "block index is -1", but code is clearly "is negative"--are lower values not reachable? --yoshi
{ {
// move the index on to 0 // move the index on to 0
_currentDataBlockIndex = 0; _currentDataBlockIndex = 0;
@ -814,7 +814,7 @@ namespace BizHawk.Emulation.Cores.Computers.SinclairSpectrum
return; return;
// don't autostop if there is only 1 block // don't autostop if there is only 1 block
if (DataBlocks.Count == 1 if (DataBlocks.Count is 1
|| _dataBlocks[_currentDataBlockIndex].BlockDescription is BlockType.CSW_Recording or BlockType.WAV_Recording) || _dataBlocks[_currentDataBlockIndex].BlockDescription is BlockType.CSW_Recording or BlockType.WAV_Recording)
{ {
return; return;

2
src/BizHawk.Emulation.Cores/Consoles/Nintendo/SNES/LibsnesCore.IMemoryDomains.cs
View File

@ -204,7 +204,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.SNES
case LibsnesApi.SNES_MAPPER.BSXROM: case LibsnesApi.SNES_MAPPER.BSXROM:
if (bank is (>= 0x40 and <= 0x7F) or >= 0xC0 if (bank is (>= 0x40 and <= 0x7F) or >= 0xC0
|| (low >= 0x8000 && bank is (>= 0x00 and <= 0x3F) or (>= 0x80 and <= 0xBF)) || (low >= 0x8000 && bank is (>= 0x00 and <= 0x3F) or (>= 0x80 and <= 0xBF))
|| (low >= 0x6000 and <= 0x7FFF && bank is >= 0x20 and <= 0x3F)) || (low is >= 0x6000 and <= 0x7FFF && bank is >= 0x20 and <= 0x3F))
{ {
return Api.QUERY_peek(LibsnesApi.SNES_MEMORY.SYSBUS, (uint)addr); return Api.QUERY_peek(LibsnesApi.SNES_MEMORY.SYSBUS, (uint)addr);
} }