From 5d03062c4c88b876493904fd7737066f1df6fdd6 Mon Sep 17 00:00:00 2001 From: adelikat Date: Sun, 15 Dec 2019 10:06:31 -0600 Subject: [PATCH] remove redundant console checks in console logging methods --- .../Lua/Libraries/EmuLuaLibrary.Console.cs | 20 +++++-------------- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/BizHawk.Client.EmuHawk/tools/Lua/Libraries/EmuLuaLibrary.Console.cs b/BizHawk.Client.EmuHawk/tools/Lua/Libraries/EmuLuaLibrary.Console.cs index 30de9ba773..0ee17b04f2 100644 --- a/BizHawk.Client.EmuHawk/tools/Lua/Libraries/EmuLuaLibrary.Console.cs +++ b/BizHawk.Client.EmuHawk/tools/Lua/Libraries/EmuLuaLibrary.Console.cs @@ -45,29 +45,20 @@ namespace BizHawk.Client.EmuHawk [LuaMethod("log", "Outputs the given object to the output box on the Lua Console dialog. Note: Can accept a LuaTable")] public static void Log(params object[] outputs) { - if (GlobalWin.Tools.Has()) - { - LogWithSeparator("\t", "\n", outputs); - } + LogWithSeparator("\t", "\n", outputs); } - //// Single param version is used by logOutputCallback of some libraries. + // Single param version is used by logOutputCallback of some libraries. public static void LogOutput(object output) { - if (GlobalWin.Tools.Has()) - { - Log(output); - } + Log(output); } [LuaMethodExample("console.writeline( \"New log line.\" );")] [LuaMethod("writeline", "Outputs the given object to the output box on the Lua Console dialog. Note: Can accept a LuaTable")] public static void WriteLine(params object[] outputs) { - if (GlobalWin.Tools.Has()) - { - LogWithSeparator("\n", "\n", outputs); - } + LogWithSeparator("\n", "\n", outputs); } [LuaMethodExample("console.write( \"New log message.\" );")] @@ -106,10 +97,9 @@ namespace BizHawk.Client.EmuHawk } else { - if (output is LuaTable) + if (output is LuaTable lti) { var sb = new StringBuilder(); - var lti = output as LuaTable; var keys = (from object key in lti.Keys select key.ToString()).ToList(); var values = (from object value in lti.Values select value.ToString()).ToList();